vim/YouCompleteMe
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Removing ycm_core.dll as allowed name

Browse Source 
I'm pretty sure that allowing ycm_core.dll was wrong. Python docs state that the
extension for compiled Python modules on Widows is "pyd"; see this link for more
details: http://docs.python.org/2/faq/windows.html#is-a-pyd-file-the-same-as-a-dll

Key quote from the page:
"Of course, foo.pyd is required if you want to say import foo."

CMakeLists.txt has been previously updated to produce a ycm_core.pyd on Windows,
not a ycm_core.dll.
This commit is contained in:
Strahinja Val Markovic 2013-02-23 16:11:15 -08:00
parent 3e5ecd6015
commit f71b003e9b
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugin/youcompleteme.vim
View File

@ -39,8 +39,6 @@ function! s:HasYcmCore()
let path_prefix = s:script_folder_path . '/../python/' let path_prefix = s:script_folder_path . '/../python/'
if filereadable(path_prefix . 'ycm_core.so') if filereadable(path_prefix . 'ycm_core.so')
return 1 return 1
elseif filereadable(path_prefix . 'ycm_core.dll')
return 1
elseif filereadable(path_prefix . 'ycm_core.pyd') elseif filereadable(path_prefix . 'ycm_core.pyd')
return 1 return 1
endif endif