From f71b003e9b4db1d127ee98e133467ed4e8b70899 Mon Sep 17 00:00:00 2001 From: Strahinja Val Markovic Date: Sat, 23 Feb 2013 16:11:15 -0800 Subject: [PATCH] Removing ycm_core.dll as allowed name I'm pretty sure that allowing ycm_core.dll was wrong. Python docs state that the extension for compiled Python modules on Widows is "pyd"; see this link for more details: http://docs.python.org/2/faq/windows.html#is-a-pyd-file-the-same-as-a-dll Key quote from the page: "Of course, foo.pyd is required if you want to say import foo." CMakeLists.txt has been previously updated to produce a ycm_core.pyd on Windows, not a ycm_core.dll. --- plugin/youcompleteme.vim | 2 -- 1 file changed, 2 deletions(-) diff --git a/plugin/youcompleteme.vim b/plugin/youcompleteme.vim index fd4c5bfa..225f6f7f 100644 --- a/plugin/youcompleteme.vim +++ b/plugin/youcompleteme.vim @@ -39,8 +39,6 @@ function! s:HasYcmCore() let path_prefix = s:script_folder_path . '/../python/' if filereadable(path_prefix . 'ycm_core.so') return 1 - elseif filereadable(path_prefix . 'ycm_core.dll') - return 1 elseif filereadable(path_prefix . 'ycm_core.pyd') return 1 endif