From f3d6a3542a02ed8e0bb52d41277cda9ac3386ceb Mon Sep 17 00:00:00 2001 From: Christian Brabandt Date: Sun, 11 Nov 2018 21:15:03 +0100 Subject: [PATCH] Revert "highlighter: also check separator groups for being defined" This reverts commit 99971aa24d612f6161e77a1622e541f582505a05. --- autoload/airline/highlighter.vim | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/autoload/airline/highlighter.vim b/autoload/airline/highlighter.vim index c732721..d7f0187 100644 --- a/autoload/airline/highlighter.vim +++ b/autoload/airline/highlighter.vim @@ -34,10 +34,6 @@ function! s:group_not_done(list, name) endif endfu -function! s:separator_name(from, to, suffix) - return a:from.'_to_'.a:to.a:suffix -endfu - function! s:get_syn(group, what) if !exists("g:airline_gui_mode") let g:airline_gui_mode = airline#init#gui_mode() @@ -182,7 +178,7 @@ function! s:exec_separator(dict, from, to, inverse, suffix) if pumvisible() return endif - let group = s:separator_name(a:from, a:to, a:suffix) + let group = a:from.'_to_'.a:to.a:suffix let l:from = airline#themes#get_highlight(a:from.a:suffix) let l:to = airline#themes#get_highlight(a:to.a:suffix) if a:inverse @@ -294,10 +290,12 @@ function! airline#highlighter#highlight(modes, ...) " nothing to be done continue endif + " TODO: optimize this for sep in items(s:separators) - if s:group_not_done(airline_grouplist, s:separator_name(sep[1][0], sep[1][1], suffix)) - call exec_separator(dict, sep[1][0], sep[1][1], sep[1][2], suffix) - endif + " we cannot check, that the group already exists, else the separators + " might not be correctly defined. But perhaps we can skip above groups + " that match the '_to_' name, because they would be redefined here... + call exec_separator(dict, sep[1][0], sep[1][1], sep[1][2], suffix) endfor endif endfor