vim/syntastic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

only run phpcs if the file has no syntax errors.

Browse Source 
running phpcs on a file which contains a parse error generates a huge
number of warnings from the phpcs library. This can freeze vim for
minutes at a time while it attempts to parse these
notices/warnings/errors.

Therefore - don't run phpcs on files which have parse errors.
This commit is contained in:
AD7six 2012-01-25 12:28:54 +01:00
parent fe5b8989af
commit 7fedd203e7
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
syntax_checkers/php.vim
View File

@ -37,13 +37,14 @@ endfunction
function! SyntaxCheckers_php_GetLocList()
let errors = []
if !g:syntastic_phpcs_disable && executable("phpcs")
let errors = s:GetPHPCSErrors()
endif
let makeprg = "php -l ".shellescape(expand('%'))
let errorformat='%-GNo syntax errors detected in%.%#,PHP Parse error: %#syntax %trror\, %m in %f on line %l,PHP Fatal %trror: %m in %f on line %l,%-GErrors parsing %.%#,%-G\s%#,Parse error: %#syntax %trror\, %m in %f on line %l,Fatal %trror: %m in %f on line %l'
let errors = errors + SyntasticMake({ 'makeprg': makeprg, 'errorformat': errorformat })
let errors = SyntasticMake({ 'makeprg': makeprg, 'errorformat': errorformat })
if empty(errors) && !g:syntastic_phpcs_disable && executable("phpcs")
let errors = errors + s:GetPHPCSErrors()
endif
call SyntasticHighlightErrors(errors, function('SyntaxCheckers_php_Term'))