vim/syntastic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1315a85aee
syntastic/syntax_checkers/python/pylint.vim

41 lines
1.3 KiB
VimL
Raw Normal View History

split python checker out into 3 files previously there were 3 checkers in the one file
2012-02-20 05:20:48 -05:00
"============================================================================
"File: pylint.vim
"Description: Syntax checking plugin for syntastic.vim
"Author: Parantapa Bhattacharya <parantapa at gmail dot com>
"
"============================================================================
add guards to all checkers goddamn I love macros
2013-02-21 10:50:41 -05:00
if exists("g:loaded_syntastic_python_pylint_checker")
finish
endif
let g:loaded_syntastic_python_pylint_checker=1
refactor how we represent and store checkers using python as a demo Add 2 classes: SyntasticChecker and SyntasticRegistry. SyntasticChecker represents a checker. It holds funcrefs to the checker func, the highlight regex func and a new `isAvailable()` func (that essentially just checks if the checker exe is installed) SyntasticRegistry is responsible for: * loading checkers * storing checkers * fetching the checkers to use according to availability and the users settings Motivation/benefits: * in the current system only one checker can be loaded per filetype * syntax checkers cant be "chained" together * the system is hard to add features to since fundamental concepts like syntax checkers and location lists arent represented explicitly Things left to do: * add a call to g:SyntasticRegistry.CreateAndRegisterChecker() to all checkers * add an `isAvailable` function to all checkers * move all checkers into `syntax_checkers/filetype/checkername.vim` - g:SyntasticRegistry assumes this layout, and its a good idea anyway for consistency and it makes it easier for users to add their own checkers Things to do after all of the above: * add a LocationList class and move all the filtering functions onto it * possibly add an Error class that wraps up each item in a loc list Random notes: * with the new system you can select the checkers to use with e.g. `let g:syntastic_python_checkers=['flake8', 'pylint']` This will try flake8 first, and if no errors are detected it will move onto pylint.
2013-01-23 19:01:30 -05:00
function! SyntaxCheckers_python_pylint_IsAvailable()
return executable('pylint')
endfunction
function! SyntaxCheckers_python_pylint_GetLocList()
update checkers to use the new syntastic#makeprg#build() Make all the easy updates. There are still quite a few to do, but in doing these ones I can see that syntastic#makeprg#build() needs to accept a few more options. Namely: * "postargs" that appear after the filename * "tail" that appears after everything - used for things like redirecting output and piping to grep/sed/etc * the filename itself - only the java checkers needed this since they specify the directory of the file to check as well There are still a few other things to do as well: * remove the options from the checkers that are now provided by syntastic#makeprg#build implicitly - i.e. the checker exe and args. * also, we need to doc the above implicit checker options
2013-01-20 06:07:05 -05:00
let makeprg = syntastic#makeprg#build({
\ 'exe': 'pylint',
refactor all the syntax checkers to use the new API and dir layout
2013-01-27 15:08:30 -05:00
\ 'args': ' -f parseable -r n -i y',
update checkers to use the new syntastic#makeprg#build() Make all the easy updates. There are still quite a few to do, but in doing these ones I can see that syntastic#makeprg#build() needs to accept a few more options. Namely: * "postargs" that appear after the filename * "tail" that appears after everything - used for things like redirecting output and piping to grep/sed/etc * the filename itself - only the java checkers needed this since they specify the directory of the file to check as well There are still a few other things to do as well: * remove the options from the checkers that are now provided by syntastic#makeprg#build implicitly - i.e. the checker exe and args. * also, we need to doc the above implicit checker options
2013-01-20 06:07:05 -05:00
\ 'subchecker': 'pylint' })
Munge the output of pylint in Vim rather than relying on sed(1).
2013-02-06 08:29:56 -05:00
let errorformat = '%f:%l:%m,%Z,%-GNo config %m'
update checkers to use the new syntastic#makeprg#build() Make all the easy updates. There are still quite a few to do, but in doing these ones I can see that syntastic#makeprg#build() needs to accept a few more options. Namely: * "postargs" that appear after the filename * "tail" that appears after everything - used for things like redirecting output and piping to grep/sed/etc * the filename itself - only the java checkers needed this since they specify the directory of the file to check as well There are still a few other things to do as well: * remove the options from the checkers that are now provided by syntastic#makeprg#build implicitly - i.e. the checker exe and args. * also, we need to doc the above implicit checker options
2013-01-20 06:07:05 -05:00
Munge the output of pylint in Vim rather than relying on sed(1).
2013-02-06 08:29:56 -05:00
let loclist=SyntasticMake({ 'makeprg': makeprg, 'errorformat': errorformat })
let n = len(loclist) - 1
while n >= 0
Off by one error, sorry. :(
2013-02-06 08:48:58 -05:00
let loclist[n]['type'] = match(['R', 'C', 'W'], loclist[n]['text'][2]) >= 0 ? 'W' : 'E'
Munge the output of pylint in Vim rather than relying on sed(1).
2013-02-06 08:29:56 -05:00
let n -= 1
endwhile
update makeprg builder and update some checkers to use it update makeprg builder: * it now accepts `fname`, `tail`, and `post_args` params. * add some doc above syntastic#makeprg#build * update a bunch of checkers to use the new params Still have quite a few checkers that arent using makeprg#build. Including all c* and a few other c-like checkers. And PHP. Not to worried about c* as these checkers are complicated and probably justify having their own logic to build makeprgs.
2013-01-20 07:27:19 -05:00
Output from pylint should be sorted.
2013-02-06 09:27:49 -05:00
return sort(loclist, 's:CmpLoclist')
endfunction
function! s:CmpLoclist(a, b)
return a:a['lnum'] - a:b['lnum']
update makeprg builder and update some checkers to use it update makeprg builder: * it now accepts `fname`, `tail`, and `post_args` params. * add some doc above syntastic#makeprg#build * update a bunch of checkers to use the new params Still have quite a few checkers that arent using makeprg#build. Including all c* and a few other c-like checkers. And PHP. Not to worried about c* as these checkers are complicated and probably justify having their own logic to build makeprgs.
2013-01-20 07:27:19 -05:00
endfunction
refactor how we represent and store checkers using python as a demo Add 2 classes: SyntasticChecker and SyntasticRegistry. SyntasticChecker represents a checker. It holds funcrefs to the checker func, the highlight regex func and a new `isAvailable()` func (that essentially just checks if the checker exe is installed) SyntasticRegistry is responsible for: * loading checkers * storing checkers * fetching the checkers to use according to availability and the users settings Motivation/benefits: * in the current system only one checker can be loaded per filetype * syntax checkers cant be "chained" together * the system is hard to add features to since fundamental concepts like syntax checkers and location lists arent represented explicitly Things left to do: * add a call to g:SyntasticRegistry.CreateAndRegisterChecker() to all checkers * add an `isAvailable` function to all checkers * move all checkers into `syntax_checkers/filetype/checkername.vim` - g:SyntasticRegistry assumes this layout, and its a good idea anyway for consistency and it makes it easier for users to add their own checkers Things to do after all of the above: * add a LocationList class and move all the filtering functions onto it * possibly add an Error class that wraps up each item in a loc list Random notes: * with the new system you can select the checkers to use with e.g. `let g:syntastic_python_checkers=['flake8', 'pylint']` This will try flake8 first, and if no errors are detected it will move onto pylint.
2013-01-23 19:01:30 -05:00
call g:SyntasticRegistry.CreateAndRegisterChecker({
\ 'filetype': 'python',
refactor all the syntax checkers to use the new API and dir layout
2013-01-27 15:08:30 -05:00
\ 'name': 'pylint' })
Reference in New Issue Copy Permalink