From 21297404190e4a273d1afa318df121a49add580a Mon Sep 17 00:00:00 2001 From: Jason Franklin Date: Sat, 9 Dec 2017 11:09:10 -0500 Subject: [PATCH] Add style improvements Function-local variables, instead of script-local variables, should be used here. In addition, "empty()" is a better choice for testing for the absence of an argument. Finally, the use of "else" is removed. The docstring is also updated to include the new argument. --- autoload/nerdtree/ui_glue.vim | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/autoload/nerdtree/ui_glue.vim b/autoload/nerdtree/ui_glue.vim index 338f5e9..60cc5dd 100644 --- a/autoload/nerdtree/ui_glue.vim +++ b/autoload/nerdtree/ui_glue.vim @@ -261,16 +261,16 @@ function! s:displayHelp() call b:NERDTree.ui.centerView() endfunction -" FUNCTION: s:findAndRevealPath() {{{1 -function! s:findAndRevealPath(userPath) - if len(a:userPath) == 0 - let s:userPath = expand("%:p") - else - let s:userPath = a:userPath +" FUNCTION: s:findAndRevealPath(path) {{{1 +function! s:findAndRevealPath(path) + let l:path = a:path + + if empty(l:path) + let l:path = expand('%:p') endif try - let p = g:NERDTreePath.New(s:userPath) + let p = g:NERDTreePath.New(l:path) catch /^NERDTree.InvalidArgumentsError/ call nerdtree#echo("no file for the current buffer") return