a0d4eb3699
As discussed in w0rp/ale#1051, there are cases where it would be useful to be able to specify the dialect explicitly. This commit allows users to do so using the ale_sh_shellcheck_dialect variable. Fixes: w0rp/ale#1051 Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
108 lines
3.3 KiB
Plaintext
108 lines
3.3 KiB
Plaintext
Before:
|
|
call ale#assert#SetUpLinterTest('sh', 'shellcheck')
|
|
call ale#test#SetFilename('test.sh')
|
|
|
|
let b:prefix = ale#path#CdString(ale#path#Simplify(g:dir))
|
|
let b:suffix = ' -f gcc -'
|
|
|
|
After:
|
|
unlet! b:is_bash
|
|
unlet! b:prefix
|
|
unlet! b:suffix
|
|
call ale#assert#TearDownLinterTest()
|
|
|
|
Execute(The default shellcheck command should be correct):
|
|
AssertLinter 'shellcheck', b:prefix . ale#Escape('shellcheck') . b:suffix
|
|
|
|
Execute(The shellcheck command should accept options):
|
|
let b:ale_sh_shellcheck_options = '--foobar'
|
|
|
|
AssertLinter 'shellcheck',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' --foobar' . b:suffix
|
|
|
|
Execute(The shellcheck command should accept options and exclusions):
|
|
let b:ale_sh_shellcheck_options = '--foobar'
|
|
let b:ale_sh_shellcheck_exclusions = 'foo,bar'
|
|
|
|
AssertLinter 'shellcheck',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' --foobar -e foo,bar' . b:suffix
|
|
|
|
Execute(The shellcheck command should include the dialect):
|
|
let b:is_bash = 1
|
|
|
|
AssertLinter 'shellcheck',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' -s bash' . b:suffix
|
|
|
|
Execute(The shellcheck command should use ale_sh_shellcheck_dialect):
|
|
let b:ale_sh_shellcheck_dialect = 'ksh93'
|
|
|
|
AssertLinter 'shellcheck',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' -s ksh93' . b:suffix
|
|
|
|
Execute(The shellcheck command should allow unspecified dialect):
|
|
let b:ale_sh_shellcheck_dialect = ''
|
|
|
|
AssertLinter 'shellcheck',
|
|
\ b:prefix . ale#Escape('shellcheck') . b:suffix
|
|
|
|
Execute(The shellcheck command should include the dialect before options and exclusions):
|
|
let b:is_bash = 1
|
|
let b:ale_sh_shellcheck_options = '--foobar'
|
|
let b:ale_sh_shellcheck_exclusions = 'foo,bar'
|
|
|
|
AssertLinter 'shellcheck', b:prefix . ale#Escape('shellcheck')
|
|
\ . ' -s bash --foobar -e foo,bar'
|
|
\ . b:suffix
|
|
|
|
Execute(The -x option should be added when the version is new enough):
|
|
AssertLinter 'shellcheck', [
|
|
\ ale#Escape('shellcheck') . ' --version',
|
|
\ b:prefix . ale#Escape('shellcheck') . b:suffix,
|
|
\]
|
|
|
|
WithChainResults [
|
|
\ 'ShellCheck - shell script analysis tool',
|
|
\ 'version: 0.4.4',
|
|
\ 'license: GNU General Public License, version 3',
|
|
\ 'website: http://www.shellcheck.net',
|
|
\]
|
|
AssertLinter 'shellcheck', [
|
|
\ ale#Escape('shellcheck') . ' --version',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' -x' . b:suffix,
|
|
\]
|
|
|
|
" We should cache the version check
|
|
WithChainResults []
|
|
AssertLinter 'shellcheck', [
|
|
\ '',
|
|
\ b:prefix . ale#Escape('shellcheck') . ' -x' . b:suffix,
|
|
\]
|
|
|
|
Execute(The -x option should not be added when the version is too old):
|
|
WithChainResults [
|
|
\ 'ShellCheck - shell script analysis tool',
|
|
\ 'version: 0.3.9',
|
|
\ 'license: GNU General Public License, version 3',
|
|
\ 'website: http://www.shellcheck.net',
|
|
\]
|
|
AssertLinter 'shellcheck', [
|
|
\ ale#Escape('shellcheck') . ' --version',
|
|
\ b:prefix . ale#Escape('shellcheck') . b:suffix,
|
|
\]
|
|
|
|
Execute(The version check shouldn't be run again for old versions):
|
|
WithChainResults [
|
|
\ 'ShellCheck - shell script analysis tool',
|
|
\ 'version: 0.3.9',
|
|
\ 'license: GNU General Public License, version 3',
|
|
\ 'website: http://www.shellcheck.net',
|
|
\]
|
|
AssertLinter 'shellcheck', [
|
|
\ ale#Escape('shellcheck') . ' --version',
|
|
\ b:prefix . ale#Escape('shellcheck') . b:suffix,
|
|
\]
|
|
AssertLinter 'shellcheck', [
|
|
\ '',
|
|
\ b:prefix . ale#Escape('shellcheck') . b:suffix,
|
|
\]
|