a6caa85a58
Although using %t to lint changes was desirable, many pylama checks use surrounding paths and file contents (e.g. C0103 module name, E0402 relative import beyond top, etc.) The more such errors I find during testing, the less %t seems like a good idea. Switch to %s. Also set `lint_file` to 1 and mark Pylama as a file linter in the docs. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
93 lines
3.2 KiB
VimL
93 lines
3.2 KiB
VimL
" Author: Kevin Locke <kevin@kevinlocke.name>
|
|
" Description: pylama for python files
|
|
|
|
call ale#Set('python_pylama_executable', 'pylama')
|
|
call ale#Set('python_pylama_options', '')
|
|
call ale#Set('python_pylama_use_global', get(g:, 'ale_use_global_executables', 0))
|
|
call ale#Set('python_pylama_auto_pipenv', 0)
|
|
call ale#Set('python_pylama_change_directory', 1)
|
|
|
|
function! ale_linters#python#pylama#GetExecutable(buffer) abort
|
|
if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_pylama_auto_pipenv'))
|
|
\ && ale#python#PipenvPresent(a:buffer)
|
|
return 'pipenv'
|
|
endif
|
|
|
|
return ale#python#FindExecutable(a:buffer, 'python_pylama', ['pylama'])
|
|
endfunction
|
|
|
|
function! ale_linters#python#pylama#GetCommand(buffer) abort
|
|
let l:cd_string = ''
|
|
|
|
if ale#Var(a:buffer, 'python_pylama_change_directory')
|
|
" Pylama loads its configuration from the current directory only, and
|
|
" applies file masks using paths relative to the current directory.
|
|
" Run from project root, if found, otherwise buffer dir.
|
|
let l:project_root = ale#python#FindProjectRoot(a:buffer)
|
|
let l:cd_string = l:project_root isnot# ''
|
|
\ ? ale#path#CdString(l:project_root)
|
|
\ : ale#path#BufferCdString(a:buffer)
|
|
endif
|
|
|
|
let l:executable = ale_linters#python#pylama#GetExecutable(a:buffer)
|
|
let l:exec_args = l:executable =~? 'pipenv$'
|
|
\ ? ' run pylama'
|
|
\ : ''
|
|
|
|
" Note: Using %t to lint changes would be preferable, but many pylama
|
|
" checks use surrounding paths (e.g. C0103 module name, E0402 relative
|
|
" import beyond top, etc.). Neither is ideal.
|
|
return l:cd_string
|
|
\ . ale#Escape(l:executable) . l:exec_args
|
|
\ . ale#Pad(ale#Var(a:buffer, 'python_pylama_options'))
|
|
\ . ' %s'
|
|
endfunction
|
|
|
|
function! ale_linters#python#pylama#Handle(buffer, lines) abort
|
|
if empty(a:lines)
|
|
return []
|
|
endif
|
|
|
|
let l:output = ale#python#HandleTraceback(a:lines, 1)
|
|
let l:pattern = '\v^.{-}:([0-9]+):([0-9]+): +%(([A-Z][0-9]+):? +)?(.*)$'
|
|
|
|
" First letter of error code is a pylint-compatible message type
|
|
" http://pylint.pycqa.org/en/latest/user_guide/output.html#source-code-analysis-section
|
|
" D is for Documentation (pydocstyle)
|
|
let l:pylint_type_to_ale_type = {
|
|
\ 'I': 'I',
|
|
\ 'R': 'W',
|
|
\ 'C': 'W',
|
|
\ 'W': 'W',
|
|
\ 'E': 'E',
|
|
\ 'F': 'E',
|
|
\ 'D': 'W',
|
|
\}
|
|
let l:pylint_type_to_ale_sub_type = {
|
|
\ 'R': 'style',
|
|
\ 'C': 'style',
|
|
\ 'D': 'style',
|
|
\}
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
call add(l:output, {
|
|
\ 'lnum': str2nr(l:match[1]),
|
|
\ 'col': str2nr(l:match[2]),
|
|
\ 'code': l:match[3],
|
|
\ 'type': get(l:pylint_type_to_ale_type, l:match[3][0], 'W'),
|
|
\ 'sub_type': get(l:pylint_type_to_ale_sub_type, l:match[3][0], ''),
|
|
\ 'text': l:match[4],
|
|
\})
|
|
endfor
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
call ale#linter#Define('python', {
|
|
\ 'name': 'pylama',
|
|
\ 'executable_callback': 'ale_linters#python#pylama#GetExecutable',
|
|
\ 'command_callback': 'ale_linters#python#pylama#GetCommand',
|
|
\ 'callback': 'ale_linters#python#pylama#Handle',
|
|
\ 'lint_file': 1,
|
|
\})
|