1f7679e619
* Remove 'col' from linters where it is hardcoded to 1 When 'col' is 1, the first column will get highlighted for no reason. It should be 0 (which is the default). In the scalac linter there was also a check about the outcome of `stridx`. It would set l:col to 0 if it was -1, and then it uses `'col': l:col + 1` to convert the outcome of `stridx` to the actual column number. This will make 'col' equals 1 when there is no match. We can remove the check because `-1 + 1 = 0`. * Remove outdated comments about vcol vcol was added as a default, and the loclists that follow these comments do not contain 'vcol' anymore Conflicts: ale_linters/elixir/dogma.vim
94 lines
3.0 KiB
VimL
94 lines
3.0 KiB
VimL
" Author: Magnus Ottenklinger - https://github.com/evnu
|
|
|
|
let g:ale_erlang_erlc_options = get(g:, 'ale_erlang_erlc_options', '')
|
|
|
|
function! ale_linters#erlang#erlc#GetCommand(buffer) abort
|
|
let l:output_file = tempname()
|
|
call ale#engine#ManageFile(a:buffer, l:output_file)
|
|
return 'erlc -o ' . fnameescape(l:output_file) . ' ' . g:ale_erlang_erlc_options . ' %t'
|
|
endfunction
|
|
|
|
function! ale_linters#erlang#erlc#Handle(buffer, lines) abort
|
|
" Matches patterns like the following:
|
|
"
|
|
" error.erl:4: variable 'B' is unbound
|
|
" error.erl:3: Warning: function main/0 is unused
|
|
" error.erl:4: Warning: variable 'A' is unused
|
|
let l:pattern = '\v^([^:]+):(\d+): (Warning: )?(.+)$'
|
|
|
|
" parse_transforms are a special case. The error message does not indicate a location:
|
|
" error.erl: undefined parse transform 'some_parse_transform'
|
|
let l:pattern_parse_transform = '\v(undefined parse transform .*)$'
|
|
let l:output = []
|
|
|
|
let l:pattern_no_module_definition = '\v(no module definition)$'
|
|
let l:pattern_unused = '\v(.* is unused)$'
|
|
|
|
let l:is_hrl = fnamemodify(bufname(a:buffer), ':e') ==# 'hrl'
|
|
|
|
for l:line in a:lines
|
|
let l:match = matchlist(l:line, l:pattern)
|
|
|
|
" Determine if the output indicates an error. We distinguish between two cases:
|
|
"
|
|
" 1) normal errors match l:pattern
|
|
" 2) parse_transform errors match l:pattern_parse_transform
|
|
"
|
|
" If none of the patterns above match, the line can be ignored
|
|
if len(l:match) == 0 " not a 'normal' warning or error
|
|
let l:match_parse_transform = matchlist(l:line, l:pattern_parse_transform)
|
|
|
|
if len(l:match_parse_transform) == 0 " also not a parse_transform error
|
|
continue
|
|
endif
|
|
|
|
call add(l:output, {
|
|
\ 'bufnr': a:buffer,
|
|
\ 'lnum': 0,
|
|
\ 'col': 0,
|
|
\ 'type': 'E',
|
|
\ 'text': l:match_parse_transform[0],
|
|
\})
|
|
|
|
continue
|
|
endif
|
|
|
|
let l:line = l:match[2]
|
|
let l:warning_or_text = l:match[3]
|
|
let l:text = l:match[4]
|
|
|
|
" If this file is a header .hrl, ignore the following expected messages:
|
|
" - 'no module definition'
|
|
" - 'X is unused'
|
|
if l:is_hrl && (
|
|
\ match(l:text, l:pattern_no_module_definition) != -1
|
|
\ || match(l:text, l:pattern_unused) != -1
|
|
\)
|
|
continue
|
|
endif
|
|
|
|
if !empty(l:warning_or_text)
|
|
let l:type = 'W'
|
|
else
|
|
let l:type = 'E'
|
|
endif
|
|
|
|
call add(l:output, {
|
|
\ 'bufnr': a:buffer,
|
|
\ 'lnum': l:line,
|
|
\ 'col': 0,
|
|
\ 'type': l:type,
|
|
\ 'text': l:text,
|
|
\})
|
|
endfor
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
call ale#linter#Define('erlang', {
|
|
\ 'name': 'erlc',
|
|
\ 'executable': 'erlc',
|
|
\ 'command_callback': 'ale_linters#erlang#erlc#GetCommand',
|
|
\ 'callback': 'ale_linters#erlang#erlc#Handle',
|
|
\})
|