56e67c5811
When set to true, and the buffer is currently inside a pipenv,
GetExecutable will return "pipenv", which will trigger the existing
functionality to append the correct pipenv arguments to run each linter.
Defaults to false.
I was going to implement ale#python#PipenvPresent by invoking
`pipenv --venv` or `pipenv --where`, but it seemed to be abominably
slow, even to the point where the test suite wasn't even finishing
("Tried to run tests 3 times"). The diff is:
diff --git a/autoload/ale/python.vim b/autoload/ale/python.vim
index 7baae079..8c100d41 100644
--- a/autoload/ale/python.vim
+++ b/autoload/ale/python.vim
@@ -106,5 +106,9 @@ endfunction
" Detects whether a pipenv environment is present.
function! ale#python#PipenvPresent(buffer) abort
- return findfile('Pipfile.lock', expand('#' . a:buffer . ':p:h') . ';') isnot# ''
+ let l:cd_string = ale#path#BufferCdString(a:buffer)
+ let l:output = systemlist(l:cd_string . 'pipenv --where')[0]
+ " `pipenv --where` returns the path to the dir containing the Pipfile
+ " if in a pipenv, or some error text otherwise.
+ return strpart(l:output, 0, 18) !=# "No Pipfile present"
endfunction
Using vim's `findfile` is much faster, behaves correctly in the majority
of situations, and also works reliably when the `pipenv` command doesn't
exist.
81 lines
2.7 KiB
VimL
81 lines
2.7 KiB
VimL
" Author: Keith Smiley <k@keith.so>, w0rp <devw0rp@gmail.com>
|
|
" Description: mypy support for optional python typechecking
|
|
|
|
call ale#Set('python_mypy_executable', 'mypy')
|
|
call ale#Set('python_mypy_ignore_invalid_syntax', 0)
|
|
call ale#Set('python_mypy_options', '')
|
|
call ale#Set('python_mypy_use_global', get(g:, 'ale_use_global_executables', 0))
|
|
call ale#Set('python_mypy_auto_pipenv', 0)
|
|
|
|
function! ale_linters#python#mypy#GetExecutable(buffer) abort
|
|
if ale#Var(a:buffer, 'python_mypy_auto_pipenv') && ale#python#PipenvPresent(a:buffer)
|
|
return 'pipenv'
|
|
endif
|
|
|
|
return ale#python#FindExecutable(a:buffer, 'python_mypy', ['mypy'])
|
|
endfunction
|
|
|
|
" The directory to change to before running mypy
|
|
function! s:GetDir(buffer) abort
|
|
let l:project_root = ale#python#FindProjectRoot(a:buffer)
|
|
|
|
return !empty(l:project_root)
|
|
\ ? l:project_root
|
|
\ : expand('#' . a:buffer . ':p:h')
|
|
endfunction
|
|
|
|
function! ale_linters#python#mypy#GetCommand(buffer) abort
|
|
let l:dir = s:GetDir(a:buffer)
|
|
let l:executable = ale_linters#python#mypy#GetExecutable(a:buffer)
|
|
|
|
let l:exec_args = l:executable =~? 'pipenv$'
|
|
\ ? ' run mypy'
|
|
\ : ''
|
|
|
|
" We have to always switch to an explicit directory for a command so
|
|
" we can know with certainty the base path for the 'filename' keys below.
|
|
return ale#path#CdString(l:dir)
|
|
\ . ale#Escape(l:executable) . l:exec_args
|
|
\ . ' --show-column-numbers '
|
|
\ . ale#Var(a:buffer, 'python_mypy_options')
|
|
\ . ' --shadow-file %s %t %s'
|
|
endfunction
|
|
|
|
function! ale_linters#python#mypy#Handle(buffer, lines) abort
|
|
let l:dir = s:GetDir(a:buffer)
|
|
" Look for lines like the following:
|
|
"
|
|
" file.py:4: error: No library stub file for module 'django.db'
|
|
"
|
|
" Lines like these should be ignored below:
|
|
"
|
|
" file.py:4: note: (Stub files are from https://github.com/python/typeshed)
|
|
let l:pattern = '\v^([a-zA-Z]?:?[^:]+):(\d+):?(\d+)?: (error|warning): (.+)$'
|
|
let l:output = []
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
" Skip invalid syntax errors if the option is on.
|
|
if l:match[5] is# 'invalid syntax'
|
|
\&& ale#Var(a:buffer, 'python_mypy_ignore_invalid_syntax')
|
|
continue
|
|
endif
|
|
|
|
call add(l:output, {
|
|
\ 'filename': ale#path#GetAbsPath(l:dir, l:match[1]),
|
|
\ 'lnum': l:match[2] + 0,
|
|
\ 'col': l:match[3] + 0,
|
|
\ 'type': l:match[4] is# 'error' ? 'E' : 'W',
|
|
\ 'text': l:match[5],
|
|
\})
|
|
endfor
|
|
|
|
return l:output
|
|
endfunction
|
|
|
|
call ale#linter#Define('python', {
|
|
\ 'name': 'mypy',
|
|
\ 'executable_callback': 'ale_linters#python#mypy#GetExecutable',
|
|
\ 'command_callback': 'ale_linters#python#mypy#GetCommand',
|
|
\ 'callback': 'ale_linters#python#mypy#Handle',
|
|
\})
|