Merge pull request #2028 from capjo/master

Fix clazy tests
This commit is contained in:
w0rp 2018-10-29 09:42:29 +00:00 committed by GitHub
commit 9dbebf1cb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,63 +1,54 @@
Before: Before:
call ale#assert#SetUpLinterTest('cpp', 'clangtidy') call ale#assert#SetUpLinterTest('cpp', 'clazy')
call ale#test#SetFilename('test.cpp') call ale#test#SetFilename('test.cpp')
After: After:
call ale#assert#TearDownLinterTest() call ale#assert#TearDownLinterTest()
Execute(The clangtidy command default should be correct): Execute(The clazy command default should be correct):
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') . ' -checks=' . ale#Escape('*') . ' %s' \ ale#Escape('clazy-standalone') . ' -checks=' . ale#Escape('level1') . ' %s'
Execute(You should be able to remove the -checks option for clang-tidy): Execute(You should be able to remove the -checks option for clazy-standalone):
let b:ale_cpp_clangtidy_checks = [] let b:ale_cpp_clazy_checks = []
AssertLinter 'clang-tidy', ale#Escape('clang-tidy') . ' %s' AssertLinter 'clazy-standalone', ale#Escape('clazy-standalone') . ' %s'
Execute(You should be able to set other checks for clang-tidy): Execute(You should be able to set other checks for clazy-standalone):
let b:ale_cpp_clangtidy_checks = ['-*', 'clang-analyzer-*'] let b:ale_cpp_clazy_checks = ['level2', 'level3']
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') \ ale#Escape('clazy-standalone')
\ . ' -checks=' . ale#Escape('-*,clang-analyzer-*') . ' %s' \ . ' -checks=' . ale#Escape('level2,level3') . ' %s'
Execute(You should be able to manually set compiler flags for clang-tidy): Execute(You should be able to manually set compiler flags for clazy-standalone):
let b:ale_cpp_clangtidy_options = '-Wall' let b:ale_cpp_clazy_options = '-qt4-compat'
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') . ' -checks=' . ale#Escape('*') . ' %s -- -Wall' \ ale#Escape('clazy-standalone') . ' -checks=' . ale#Escape('level1') . ' -qt4-compat' . ' %s'
\ \
Execute(The build directory should be configurable): Execute(The build directory should be configurable):
let b:ale_c_build_dir = '/foo/bar' let b:ale_c_build_dir = '/foo/bar'
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') \ ale#Escape('clazy-standalone')
\ . ' -checks=' . ale#Escape('*') . ' %s -p ' . ale#Escape('/foo/bar') \ . ' -checks=' . ale#Escape('level1') . ' -p ' . ale#Escape('/foo/bar') . ' %s'
Execute(The build directory setting should override the options):
let b:ale_c_build_dir = '/foo/bar'
let b:ale_cpp_clangtidy_options = '-Wall'
AssertLinter 'clang-tidy',
\ ale#Escape('clang-tidy')
\ . ' -checks=' . ale#Escape('*') . ' %s -p ' . ale#Escape('/foo/bar')
Execute(The build directory should be ignored for header files): Execute(The build directory should be ignored for header files):
call ale#test#SetFilename('test.h') call ale#test#SetFilename('test.h')
let b:ale_c_build_dir = '/foo/bar' let b:ale_c_build_dir = '/foo/bar'
let b:ale_cpp_clangtidy_options = '-Wall'
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') . ' -checks=' . ale#Escape('*') . ' %s -- -Wall' \ ale#Escape('clazy-standalone') . ' -checks=' . ale#Escape('level1') . ' %s'
call ale#test#SetFilename('test.hpp') call ale#test#SetFilename('test.hpp')
AssertLinter 'clang-tidy', AssertLinter 'clazy-standalone',
\ ale#Escape('clang-tidy') . ' -checks=' . ale#Escape('*') . ' %s -- -Wall' \ ale#Escape('clazy-standalone') . ' -checks=' . ale#Escape('level1') . ' %s'
Execute(The executable should be configurable): Execute(The executable should be configurable):
let b:ale_cpp_clangtidy_executable = 'foobar' let b:ale_cpp_clazy_executable = 'foobar'
AssertLinter 'foobar', AssertLinter 'foobar',
\ ale#Escape('foobar') . ' -checks=' . ale#Escape('*') . ' %s' \ ale#Escape('foobar') . ' -checks=' . ale#Escape('level1') . ' %s'