vim/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge pull request #2543 from hsanson/fix-checkstyle-handler

Browse Source 
Fix java checkstyle handler.
This commit is contained in:
w0rp 2019-05-29 20:16:51 +01:00 committed by GitHub
commit 6b819dd74a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ale_linters/java/checkstyle.vim
View File

@ -17,6 +17,10 @@ function! ale_linters#java#checkstyle#Handle(buffer, lines) abort
\}) \})
endfor endfor
if !empty(l:output)
return l:output
endif
" old checkstyle versions " old checkstyle versions
let l:pattern = '\v(.+):(\d+): ([^:]+): (.+)$' let l:pattern = '\v(.+):(\d+): ([^:]+): (.+)$'

8
test/handler/test_checkstyle_handler.vader
View File

@ -21,10 +21,18 @@ Execute(The checkstyle handler should parse lines correctly):
\ 'code': 'JavadocMethod', \ 'code': 'JavadocMethod',
\ 'type': 'W', \ 'type': 'W',
\ }, \ },
\ {
\ 'lnum': 11,
\ 'col': 7,
\ 'text': 'WhitespaceAround: ''if'' is not followed by whitespace.',
\ 'code': 'WhitespaceAround',
\ 'type': 'W',
\ },
\ ], \ ],
\ ale_linters#java#checkstyle#Handle(666, [ \ ale_linters#java#checkstyle#Handle(666, [
\ '[WARN] whatever:101: ''method def rcurly'' has incorrect indentation level 4, expected level should be 2. [Indentation]', \ '[WARN] whatever:101: ''method def rcurly'' has incorrect indentation level 4, expected level should be 2. [Indentation]',
\ '[WARN] whatever:63:3: Missing a Javadoc comment. [JavadocMethod]', \ '[WARN] whatever:63:3: Missing a Javadoc comment. [JavadocMethod]',
\ '[WARN] whatever:11:7: WhitespaceAround: ''if'' is not followed by whitespace. [WhitespaceAround]',
\ ]) \ ])
Execute(The checkstyle handler should parse lines from older checkstyle versions correctly): Execute(The checkstyle handler should parse lines from older checkstyle versions correctly):