vim/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Set better highlights for write-good

Browse Source
This commit is contained in:
w0rp 2017-10-25 00:58:10 +01:00
parent 94bdabb8c3
commit 5029078df3
2 changed files with 39 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
autoload/ale/handlers/writegood.vim
View File

@ -31,19 +31,30 @@ function! ale#handlers#writegood#Handle(buffer, lines) abort
" "
" "it is" is wordy or unneeded on line 20 at column 53 " "it is" is wordy or unneeded on line 20 at column 53
" "easily" can weaken meaning on line 154 at column 29 " "easily" can weaken meaning on line 154 at column 29
let l:marks_pattern = '\v^ *(\^+) *$'
let l:pattern = '\v^(".*"\s.*)\son\sline\s(\d+)\sat\scolumn\s(\d+)$' let l:pattern = '\v^(".*"\s.*)\son\sline\s(\d+)\sat\scolumn\s(\d+)$'
let l:output = [] let l:output = []
let l:last_len = 0
for l:match in ale#util#GetMatches(a:lines, l:pattern) for l:match in ale#util#GetMatches(a:lines, [l:marks_pattern, l:pattern])
" Add the linter error. Note that we need to add 1 to the col because if empty(l:match[2])
" write-good reports the column corresponding to the space before the let l:last_len = len(l:match[1])
" offending word or phrase. else
call add(l:output, { let l:col = l:match[3] + 1
\ 'text': l:match[1],
\ 'lnum': l:match[2] + 0, " Add the linter error. Note that we need to add 1 to the col because
\ 'col': l:match[3] + 1, " write-good reports the column corresponding to the space before the
\ 'type': 'W', " offending word or phrase.
\}) call add(l:output, {
\ 'text': l:match[1],
\ 'lnum': l:match[2] + 0,
\ 'col': l:col,
\ 'end_col': l:last_len ? (l:col + l:last_len - 1) : l:col,
\ 'type': 'W',
\})
let l:last_len = 0
endif
endfor endfor
return l:output return l:output

20
test/handler/test_write_good_handler.vader
View File

@ -4,9 +4,24 @@ Execute(The write-good handler should handle the example from the write-good REA
\ { \ {
\ 'lnum': 1, \ 'lnum': 1,
\ 'col': 1, \ 'col': 1,
\ 'end_col': 2,
\ 'type': 'W', \ 'type': 'W',
\ 'text': '"So" adds no meaning', \ 'text': '"So" adds no meaning',
\ } \ },
\ {
\ 'lnum': 1,
\ 'col': 12,
\ 'end_col': 21,
\ 'type': 'W',
\ 'text': '"was stolen" may be passive voice',
\ },
\ {
\ 'lnum': 6,
\ 'col': 2,
\ 'end_col': 2,
\ 'type': 'W',
\ 'text': '"foo bar" bla',
\ },
\ ], \ ],
\ ale#handlers#writegood#Handle(bufnr(''), [ \ ale#handlers#writegood#Handle(bufnr(''), [
\ 'In /tmp/vBYivbZ/6/test.md', \ 'In /tmp/vBYivbZ/6/test.md',
@ -17,5 +32,6 @@ Execute(The write-good handler should handle the example from the write-good REA
\ '-------------', \ '-------------',
\ 'So the cat was stolen.', \ 'So the cat was stolen.',
\ ' ^^^^^^^^^^', \ ' ^^^^^^^^^^',
\ '"was stolen" may be passive voice on line 1 at column 11 ', \ '"was stolen" may be passive voice on line 1 at column 11',
\ '"foo bar" bla on line 6 at column 1',
\ ]) \ ])