vim/ale
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Correct related information line numbers from 0-based to 1-based

Browse Source
This commit is contained in:
Fred Emmott 2018-08-15 14:46:57 -07:00
parent 764da48c57
commit 4923d48d53
No known key found for this signature in database
GPG Key ID: 06C22A9D789FCA28
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
autoload/ale/lsp/response.vim
View File

@ -59,10 +59,11 @@ function! ale#lsp#response#ReadDiagnostics(response) abort
let l:related = deepcopy(l:diagnostic.relatedInformation)
call map(l:related, {key, val ->
\ ale#path#FromURI(val.location.uri) .
\ ':' . val.location.range.start.line . ':' . val.location.range.start.character .
\ ':' . (val.location.range.start.line + 1) .
\ ':' . (val.location.range.start.character + 1) .
\ ":\n\t" . val.message
\ })
let l:loclist_item.detail = l:diagnostic.message . "\n" . join(l:related, "\n") . "\n"
let l:loclist_item.detail = l:diagnostic.message . "\n" . join(l:related, "\n")
endif
call add(l:loclist, l:loclist_item)

4
test/lsp/test_read_lsp_diagnostics.vader
View File

@ -149,7 +149,7 @@ Execute(ale#lsp#response#ReadDiagnostics() should use relatedInformation for det
\ 'col': 3,
\ 'end_lnum': 1,
\ 'end_col': 3,
\ 'detail': "Something went wrong!\n/tmp/someotherfile.txt:42:79:\n\tmight be this"
\ 'detail': "Something went wrong!\n/tmp/someotherfile.txt:43:80:\n\tmight be this"
\ }
\ ],
\ ale#lsp#response#ReadDiagnostics({'params': {'uri': 'filename.ts', 'diagnostics': [
@ -162,7 +162,7 @@ Execute(ale#lsp#response#ReadDiagnostics() should use relatedInformation for det
\ 'uri': 'file:///tmp/someotherfile.txt',
\ 'range': {
\ 'start': { 'line': 42, 'character': 79 },
\ 'end': { 'line': 43, 'character': 80 },
\ 'end': { 'line': 142, 'character': 179},
\ }
\ }
\ }]