From 1a69c9c88ccb97655ee75c9fe02dcc81bc228626 Mon Sep 17 00:00:00 2001 From: w0rp Date: Fri, 15 Feb 2019 10:42:34 +0000 Subject: [PATCH] #2295 Send an empty object for the initialized notification, per the spec --- autoload/ale/lsp/message.vim | 2 +- test/lsp/test_lsp_client_messages.vader | 2 +- test/lsp/test_other_initialize_message_handling.vader | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/autoload/ale/lsp/message.vim b/autoload/ale/lsp/message.vim index cc0b2227..dd07685a 100644 --- a/autoload/ale/lsp/message.vim +++ b/autoload/ale/lsp/message.vim @@ -41,7 +41,7 @@ function! ale#lsp#message#Initialize(root_path, initialization_options) abort endfunction function! ale#lsp#message#Initialized() abort - return [1, 'initialized'] + return [1, 'initialized', {}] endfunction function! ale#lsp#message#Shutdown() abort diff --git a/test/lsp/test_lsp_client_messages.vader b/test/lsp/test_lsp_client_messages.vader index bdede460..e0e2ef20 100644 --- a/test/lsp/test_lsp_client_messages.vader +++ b/test/lsp/test_lsp_client_messages.vader @@ -23,7 +23,7 @@ Execute(ale#lsp#message#Initialize() should return correct messages): \ ale#lsp#message#Initialize('/foo/bar', {'foo': 'bar'}) Execute(ale#lsp#message#Initialized() should return correct messages): - AssertEqual [1, 'initialized'], ale#lsp#message#Initialized() + AssertEqual [1, 'initialized', {}], ale#lsp#message#Initialized() Execute(ale#lsp#message#Shutdown() should return correct messages): AssertEqual [0, 'shutdown'], ale#lsp#message#Shutdown() diff --git a/test/lsp/test_other_initialize_message_handling.vader b/test/lsp/test_other_initialize_message_handling.vader index 4150b9d7..0372765d 100644 --- a/test/lsp/test_other_initialize_message_handling.vader +++ b/test/lsp/test_other_initialize_message_handling.vader @@ -43,7 +43,7 @@ Execute(Messages with no method and capabilities should initialize projects): \}) AssertEqual 1, b:conn.initialized - AssertEqual [[1, 'initialized']], g:message_list + AssertEqual [[1, 'initialized', {}]], g:message_list Execute(Other messages should not initialize projects): call ale#lsp#HandleInitResponse(b:conn, {'method': 'lolwat'}) @@ -102,7 +102,7 @@ Execute(Capabilities should bet set up correctly): \ 'symbol_search': 1, \ }, \ b:conn.capabilities - AssertEqual [[1, 'initialized']], g:message_list + AssertEqual [[1, 'initialized', {}]], g:message_list Execute(Disabled capabilities should be recognised correctly): call ale#lsp#HandleInitResponse(b:conn, { @@ -145,7 +145,7 @@ Execute(Disabled capabilities should be recognised correctly): \ 'symbol_search': 0, \ }, \ b:conn.capabilities - AssertEqual [[1, 'initialized']], g:message_list + AssertEqual [[1, 'initialized', {}]], g:message_list Execute(Results that are not dictionaries should be handled correctly): call ale#lsp#HandleInitResponse(b:conn, {