2016-10-03 14:55:55 -04:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: flake8 for python files
|
|
|
|
|
2018-05-28 11:34:54 -04:00
|
|
|
call ale#Set('python_flake8_executable', 'flake8')
|
2018-07-04 03:36:34 -04:00
|
|
|
call ale#Set('python_flake8_options', '')
|
2018-05-28 11:34:54 -04:00
|
|
|
call ale#Set('python_flake8_use_global', get(g:, 'ale_use_global_executables', 0))
|
|
|
|
call ale#Set('python_flake8_change_directory', 1)
|
Add python_[linter]_auto_pipenv options for python linters (fixes #1656)
When set to true, and the buffer is currently inside a pipenv,
GetExecutable will return "pipenv", which will trigger the existing
functionality to append the correct pipenv arguments to run each linter.
Defaults to false.
I was going to implement ale#python#PipenvPresent by invoking
`pipenv --venv` or `pipenv --where`, but it seemed to be abominably
slow, even to the point where the test suite wasn't even finishing
("Tried to run tests 3 times"). The diff is:
diff --git a/autoload/ale/python.vim b/autoload/ale/python.vim
index 7baae079..8c100d41 100644
--- a/autoload/ale/python.vim
+++ b/autoload/ale/python.vim
@@ -106,5 +106,9 @@ endfunction
" Detects whether a pipenv environment is present.
function! ale#python#PipenvPresent(buffer) abort
- return findfile('Pipfile.lock', expand('#' . a:buffer . ':p:h') . ';') isnot# ''
+ let l:cd_string = ale#path#BufferCdString(a:buffer)
+ let l:output = systemlist(l:cd_string . 'pipenv --where')[0]
+ " `pipenv --where` returns the path to the dir containing the Pipfile
+ " if in a pipenv, or some error text otherwise.
+ return strpart(l:output, 0, 18) !=# "No Pipfile present"
endfunction
Using vim's `findfile` is much faster, behaves correctly in the majority
of situations, and also works reliably when the `pipenv` command doesn't
exist.
2018-07-11 23:02:23 -04:00
|
|
|
call ale#Set('python_flake8_auto_pipenv', 0)
|
2016-11-14 12:52:31 -05:00
|
|
|
|
2017-05-07 11:31:33 -04:00
|
|
|
function! s:UsingModule(buffer) abort
|
|
|
|
return ale#Var(a:buffer, 'python_flake8_options') =~# ' *-m flake8'
|
|
|
|
endfunction
|
|
|
|
|
2016-11-14 12:52:31 -05:00
|
|
|
function! ale_linters#python#flake8#GetExecutable(buffer) abort
|
2018-09-15 21:38:26 -04:00
|
|
|
if (ale#Var(a:buffer, 'python_auto_pipenv') || ale#Var(a:buffer, 'python_flake8_auto_pipenv'))
|
|
|
|
\ && ale#python#PipenvPresent(a:buffer)
|
Add python_[linter]_auto_pipenv options for python linters (fixes #1656)
When set to true, and the buffer is currently inside a pipenv,
GetExecutable will return "pipenv", which will trigger the existing
functionality to append the correct pipenv arguments to run each linter.
Defaults to false.
I was going to implement ale#python#PipenvPresent by invoking
`pipenv --venv` or `pipenv --where`, but it seemed to be abominably
slow, even to the point where the test suite wasn't even finishing
("Tried to run tests 3 times"). The diff is:
diff --git a/autoload/ale/python.vim b/autoload/ale/python.vim
index 7baae079..8c100d41 100644
--- a/autoload/ale/python.vim
+++ b/autoload/ale/python.vim
@@ -106,5 +106,9 @@ endfunction
" Detects whether a pipenv environment is present.
function! ale#python#PipenvPresent(buffer) abort
- return findfile('Pipfile.lock', expand('#' . a:buffer . ':p:h') . ';') isnot# ''
+ let l:cd_string = ale#path#BufferCdString(a:buffer)
+ let l:output = systemlist(l:cd_string . 'pipenv --where')[0]
+ " `pipenv --where` returns the path to the dir containing the Pipfile
+ " if in a pipenv, or some error text otherwise.
+ return strpart(l:output, 0, 18) !=# "No Pipfile present"
endfunction
Using vim's `findfile` is much faster, behaves correctly in the majority
of situations, and also works reliably when the `pipenv` command doesn't
exist.
2018-07-11 23:02:23 -04:00
|
|
|
return 'pipenv'
|
|
|
|
endif
|
|
|
|
|
2017-07-05 08:07:55 -04:00
|
|
|
if !s:UsingModule(a:buffer)
|
|
|
|
return ale#python#FindExecutable(a:buffer, 'python_flake8', ['flake8'])
|
2017-05-07 11:16:17 -04:00
|
|
|
endif
|
|
|
|
|
2017-04-15 20:24:08 -04:00
|
|
|
return ale#Var(a:buffer, 'python_flake8_executable')
|
2016-11-14 12:52:31 -05:00
|
|
|
endfunction
|
|
|
|
|
2017-02-06 06:12:21 -05:00
|
|
|
function! ale_linters#python#flake8#VersionCheck(buffer) abort
|
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
|
|
|
|
" If we have previously stored the version number in a cache, then
|
|
|
|
" don't look it up again.
|
2017-11-09 18:42:54 -05:00
|
|
|
if ale#semver#HasVersion(l:executable)
|
2017-02-06 06:12:21 -05:00
|
|
|
" Returning an empty string skips this command.
|
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
|
2017-11-09 18:42:54 -05:00
|
|
|
let l:executable = ale#Escape(l:executable)
|
2017-05-07 11:31:33 -04:00
|
|
|
let l:module_string = s:UsingModule(a:buffer) ? ' -m flake8' : ''
|
|
|
|
|
|
|
|
return l:executable . l:module_string . ' --version'
|
2017-02-06 06:12:21 -05:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#python#flake8#GetCommand(buffer, version_output) abort
|
2018-05-28 11:34:54 -04:00
|
|
|
let l:cd_string = ale#Var(a:buffer, 'python_flake8_change_directory')
|
|
|
|
\ ? ale#path#BufferCdString(a:buffer)
|
|
|
|
\ : ''
|
2017-11-09 18:42:54 -05:00
|
|
|
let l:executable = ale_linters#python#flake8#GetExecutable(a:buffer)
|
|
|
|
let l:version = ale#semver#GetVersion(l:executable, a:version_output)
|
2017-02-06 06:12:21 -05:00
|
|
|
|
2018-06-02 21:49:12 -04:00
|
|
|
let l:exec_args = l:executable =~? 'pipenv$'
|
|
|
|
\ ? ' run flake8'
|
|
|
|
\ : ''
|
|
|
|
|
2017-02-06 06:12:21 -05:00
|
|
|
" Only include the --stdin-display-name argument if we can parse the
|
|
|
|
" flake8 version, and it is recent enough to support it.
|
2017-11-09 18:42:54 -05:00
|
|
|
let l:display_name_args = ale#semver#GTE(l:version, [3, 0, 0])
|
2017-05-07 11:16:17 -04:00
|
|
|
\ ? ' --stdin-display-name %s'
|
2017-02-06 06:12:21 -05:00
|
|
|
\ : ''
|
|
|
|
|
2017-05-07 11:16:17 -04:00
|
|
|
let l:options = ale#Var(a:buffer, 'python_flake8_options')
|
|
|
|
|
2018-04-26 19:53:44 -04:00
|
|
|
return l:cd_string
|
2018-06-02 21:49:12 -04:00
|
|
|
\ . ale#Escape(l:executable) . l:exec_args
|
2017-05-07 11:16:17 -04:00
|
|
|
\ . (!empty(l:options) ? ' ' . l:options : '')
|
2017-08-10 04:58:32 -04:00
|
|
|
\ . ' --format=default'
|
2017-05-07 11:16:17 -04:00
|
|
|
\ . l:display_name_args . ' -'
|
2016-11-14 12:52:31 -05:00
|
|
|
endfunction
|
|
|
|
|
2017-06-14 11:20:30 -04:00
|
|
|
let s:end_col_pattern_map = {
|
|
|
|
\ 'F405': '\(.\+\) may be undefined',
|
|
|
|
\ 'F821': 'undefined name ''\([^'']\+\)''',
|
|
|
|
\ 'F999': '^''\([^'']\+\)''',
|
|
|
|
\ 'F841': 'local variable ''\([^'']\+\)''',
|
|
|
|
\}
|
|
|
|
|
|
|
|
function! ale_linters#python#flake8#Handle(buffer, lines) abort
|
|
|
|
for l:line in a:lines[:10]
|
|
|
|
if match(l:line, '^Traceback') >= 0
|
|
|
|
return [{
|
|
|
|
\ 'lnum': 1,
|
|
|
|
\ 'text': 'An exception was thrown. See :ALEDetail',
|
|
|
|
\ 'detail': join(a:lines, "\n"),
|
|
|
|
\}]
|
|
|
|
endif
|
|
|
|
endfor
|
|
|
|
|
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
|
|
|
" stdin:6:6: E111 indentation is not a multiple of four
|
|
|
|
let l:pattern = '\v^[a-zA-Z]?:?[^:]+:(\d+):?(\d+)?: ([[:alnum:]]+) (.*)$'
|
|
|
|
let l:output = []
|
|
|
|
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
|
|
let l:code = l:match[3]
|
|
|
|
|
2017-08-08 03:39:13 -04:00
|
|
|
if (l:code is# 'W291' || l:code is# 'W293')
|
2017-06-14 11:20:30 -04:00
|
|
|
\ && !ale#Var(a:buffer, 'warn_about_trailing_whitespace')
|
|
|
|
" Skip warnings for trailing whitespace if the option is off.
|
|
|
|
continue
|
|
|
|
endif
|
|
|
|
|
2017-11-28 05:08:34 -05:00
|
|
|
if l:code is# 'W391'
|
|
|
|
\&& !ale#Var(a:buffer, 'warn_about_trailing_blank_lines')
|
|
|
|
" Skip warnings for trailing blank lines if the option is off
|
|
|
|
continue
|
|
|
|
endif
|
|
|
|
|
2017-06-14 11:20:30 -04:00
|
|
|
let l:item = {
|
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
2017-11-14 04:41:29 -05:00
|
|
|
\ 'text': l:match[4],
|
|
|
|
\ 'code': l:code,
|
2017-06-14 11:40:03 -04:00
|
|
|
\ 'type': 'W',
|
2017-06-14 11:20:30 -04:00
|
|
|
\}
|
|
|
|
|
2018-02-18 04:44:04 -05:00
|
|
|
if l:code[:0] is# 'F'
|
|
|
|
if l:code isnot# 'F401'
|
|
|
|
let l:item.type = 'E'
|
|
|
|
endif
|
2017-08-08 03:39:13 -04:00
|
|
|
elseif l:code[:0] is# 'E'
|
2017-06-14 11:40:03 -04:00
|
|
|
let l:item.type = 'E'
|
2018-02-18 04:44:04 -05:00
|
|
|
|
|
|
|
if l:code isnot# 'E999' && l:code isnot# 'E112'
|
|
|
|
let l:item.sub_type = 'style'
|
|
|
|
endif
|
2017-08-08 03:39:13 -04:00
|
|
|
elseif l:code[:0] is# 'W'
|
2017-06-14 11:40:03 -04:00
|
|
|
let l:item.sub_type = 'style'
|
|
|
|
endif
|
|
|
|
|
2017-06-14 11:20:30 -04:00
|
|
|
let l:end_col_pattern = get(s:end_col_pattern_map, l:code, '')
|
|
|
|
|
|
|
|
if !empty(l:end_col_pattern)
|
|
|
|
let l:end_col_match = matchlist(l:match[4], l:end_col_pattern)
|
|
|
|
|
|
|
|
if !empty(l:end_col_match)
|
|
|
|
let l:item.end_col = l:item.col + len(l:end_col_match[1]) - 1
|
|
|
|
endif
|
|
|
|
endif
|
|
|
|
|
|
|
|
call add(l:output, l:item)
|
|
|
|
endfor
|
|
|
|
|
|
|
|
return l:output
|
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('python', {
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'name': 'flake8',
|
2016-11-14 12:52:31 -05:00
|
|
|
\ 'executable_callback': 'ale_linters#python#flake8#GetExecutable',
|
2017-02-06 06:12:21 -05:00
|
|
|
\ 'command_chain': [
|
|
|
|
\ {'callback': 'ale_linters#python#flake8#VersionCheck'},
|
2017-05-31 10:19:58 -04:00
|
|
|
\ {'callback': 'ale_linters#python#flake8#GetCommand', 'output_stream': 'both'},
|
2017-02-06 06:12:21 -05:00
|
|
|
\ ],
|
2017-06-14 11:20:30 -04:00
|
|
|
\ 'callback': 'ale_linters#python#flake8#Handle',
|
2016-09-13 17:23:37 -04:00
|
|
|
\})
|