2017-06-29 08:08:51 -04:00
|
|
|
" Author: Vincent Lequertier <https://github.com/SkySymbol>, Chris Weyl <cweyl@alumni.drew.edu>
|
2016-10-09 11:31:03 -04:00
|
|
|
" Description: This file adds support for checking perl with perl critic
|
|
|
|
|
2017-06-29 08:08:51 -04:00
|
|
|
let g:ale_perl_perlcritic_executable =
|
|
|
|
\ get(g:, 'ale_perl_perlcritic_executable', 'perlcritic')
|
|
|
|
|
|
|
|
let g:ale_perl_perlcritic_profile =
|
|
|
|
\ get(g:, 'ale_perl_perlcritic_profile', '.perlcriticrc')
|
|
|
|
|
|
|
|
let g:ale_perl_perlcritic_options =
|
|
|
|
\ get(g:, 'ale_perl_perlcritic_options', '')
|
|
|
|
|
|
|
|
let g:ale_perl_perlcritic_showrules =
|
|
|
|
\ get(g:, 'ale_perl_perlcritic_showrules', 0)
|
|
|
|
|
|
|
|
function! ale_linters#perl#perlcritic#GetExecutable(buffer) abort
|
|
|
|
return ale#Var(a:buffer, 'perl_perlcritic_executable')
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#perl#perlcritic#GetProfile(buffer) abort
|
|
|
|
|
|
|
|
" first see if we've been overridden
|
|
|
|
let l:profile = ale#Var(a:buffer, 'perl_perlcritic_profile')
|
2017-08-08 03:39:13 -04:00
|
|
|
if l:profile is? ''
|
2017-06-29 08:08:51 -04:00
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
|
|
|
|
" otherwise, iterate upwards to find it
|
|
|
|
return ale#path#FindNearestFile(a:buffer, l:profile)
|
|
|
|
endfunction
|
2017-06-11 16:13:47 -04:00
|
|
|
|
|
|
|
function! ale_linters#perl#perlcritic#GetCommand(buffer) abort
|
|
|
|
let l:critic_verbosity = '%l:%c %m\n'
|
2017-06-29 08:08:51 -04:00
|
|
|
if ale#Var(a:buffer, 'perl_perlcritic_showrules')
|
2017-06-11 16:13:47 -04:00
|
|
|
let l:critic_verbosity = '%l:%c %m [%p]\n'
|
|
|
|
endif
|
|
|
|
|
2017-06-29 08:08:51 -04:00
|
|
|
let l:profile = ale_linters#perl#perlcritic#GetProfile(a:buffer)
|
|
|
|
let l:options = ale#Var(a:buffer, 'perl_perlcritic_options')
|
|
|
|
|
|
|
|
let l:command = ale#Escape(ale_linters#perl#perlcritic#GetExecutable(a:buffer))
|
|
|
|
\ . " --verbose '". l:critic_verbosity . "' --nocolor"
|
|
|
|
|
2017-08-10 19:31:42 -04:00
|
|
|
if l:profile isnot? ''
|
2017-06-29 08:08:51 -04:00
|
|
|
let l:command .= ' --profile ' . ale#Escape(l:profile)
|
|
|
|
endif
|
2017-08-10 19:31:42 -04:00
|
|
|
if l:options isnot? ''
|
2017-06-29 08:08:51 -04:00
|
|
|
let l:command .= ' ' . l:options
|
|
|
|
endif
|
|
|
|
|
|
|
|
return l:command
|
2017-06-11 16:13:47 -04:00
|
|
|
endfunction
|
|
|
|
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#perl#perlcritic#Handle(buffer, lines) abort
|
2017-06-11 16:13:47 -04:00
|
|
|
let l:pattern = '\(\d\+\):\(\d\+\) \(.\+\)'
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:output = []
|
2016-10-09 11:31:03 -04:00
|
|
|
|
2017-04-17 19:35:53 -04:00
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
2016-10-10 19:43:45 -04:00
|
|
|
call add(l:output, {
|
2017-06-11 16:13:47 -04:00
|
|
|
\ 'lnum': l:match[1],
|
|
|
|
\ 'col': l:match[2],
|
|
|
|
\ 'text': l:match[3],
|
2016-10-09 11:31:03 -04:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
return l:output
|
2016-10-09 11:31:03 -04:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('perl', {
|
2016-10-09 11:31:03 -04:00
|
|
|
\ 'name': 'perlcritic',
|
2017-01-03 14:55:23 -05:00
|
|
|
\ 'output_stream': 'stdout',
|
2017-06-29 08:08:51 -04:00
|
|
|
\ 'executable_callback': 'ale_linters#perl#perlcritic#GetExecutable',
|
2017-06-11 16:13:47 -04:00
|
|
|
\ 'command_callback': 'ale_linters#perl#perlcritic#GetCommand',
|
2016-10-09 11:31:03 -04:00
|
|
|
\ 'callback': 'ale_linters#perl#perlcritic#Handle',
|
|
|
|
\})
|