2016-10-03 14:55:55 -04:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: eslint for JavaScript files
|
|
|
|
|
2016-10-06 08:42:52 -04:00
|
|
|
let g:ale_javascript_eslint_executable =
|
|
|
|
\ get(g:, 'ale_javascript_eslint_executable', 'eslint')
|
|
|
|
|
2017-01-05 03:12:36 -05:00
|
|
|
let g:ale_javascript_eslint_options =
|
|
|
|
\ get(g:, 'ale_javascript_eslint_options', '')
|
|
|
|
|
2016-10-23 08:04:41 -04:00
|
|
|
let g:ale_javascript_eslint_use_global =
|
|
|
|
\ get(g:, 'ale_javascript_eslint_use_global', 0)
|
|
|
|
|
|
|
|
function! ale_linters#javascript#eslint#GetExecutable(buffer) abort
|
2017-04-15 20:24:08 -04:00
|
|
|
if ale#Var(a:buffer, 'javascript_eslint_use_global')
|
|
|
|
return ale#Var(a:buffer, 'javascript_eslint_executable')
|
2016-10-23 08:04:41 -04:00
|
|
|
endif
|
|
|
|
|
2017-03-28 19:21:27 -04:00
|
|
|
" Look for the kinds of paths that create-react-app generates first.
|
|
|
|
let l:executable = ale#util#ResolveLocalPath(
|
|
|
|
\ a:buffer,
|
|
|
|
\ 'node_modules/eslint/bin/eslint.js',
|
|
|
|
\ ''
|
|
|
|
\)
|
|
|
|
|
|
|
|
if !empty(l:executable)
|
|
|
|
return l:executable
|
|
|
|
endif
|
|
|
|
|
2016-10-23 08:04:41 -04:00
|
|
|
return ale#util#ResolveLocalPath(
|
|
|
|
\ a:buffer,
|
|
|
|
\ 'node_modules/.bin/eslint',
|
2017-04-15 20:24:08 -04:00
|
|
|
\ ale#Var(a:buffer, 'javascript_eslint_executable')
|
2016-10-23 08:04:41 -04:00
|
|
|
\)
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
function! ale_linters#javascript#eslint#GetCommand(buffer) abort
|
|
|
|
return ale_linters#javascript#eslint#GetExecutable(a:buffer)
|
2017-04-15 20:24:08 -04:00
|
|
|
\ . ' ' . ale#Var(a:buffer, 'javascript_eslint_options')
|
2016-10-23 08:04:41 -04:00
|
|
|
\ . ' -f unix --stdin --stdin-filename %s'
|
|
|
|
endfunction
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#javascript#eslint#Handle(buffer, lines) abort
|
2017-03-09 16:05:00 -05:00
|
|
|
let l:config_error_pattern = '\v^ESLint couldn''t find a configuration file'
|
|
|
|
\ . '|^Cannot read config file'
|
|
|
|
|
|
|
|
" Look for a message in the first few lines which indicates that
|
|
|
|
" a configuration file couldn't be found.
|
|
|
|
for l:line in a:lines[:10]
|
|
|
|
if len(matchlist(l:line, l:config_error_pattern)) > 0
|
|
|
|
return [{
|
|
|
|
\ 'lnum': 1,
|
|
|
|
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
|
|
|
|
\ 'detail': join(a:lines, "\n"),
|
|
|
|
\}]
|
|
|
|
endif
|
|
|
|
endfor
|
|
|
|
|
2016-09-08 19:23:26 -04:00
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
2016-10-04 08:50:44 -04:00
|
|
|
" /path/to/some-filename.js:47:14: Missing trailing comma. [Warning/comma-dangle]
|
|
|
|
" /path/to/some-filename.js:56:41: Missing semicolon. [Error/semi]
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) \[\(.\+\)\]$'
|
2016-12-22 06:16:22 -05:00
|
|
|
" This second pattern matches lines like the following:
|
|
|
|
"
|
|
|
|
" /path/to/some-filename.js:13:3: Parsing error: Unexpected token
|
|
|
|
let l:parsing_pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\)$'
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:output = []
|
2016-09-08 19:23:26 -04:00
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
for l:line in a:lines
|
|
|
|
let l:match = matchlist(l:line, l:pattern)
|
2016-09-08 19:23:26 -04:00
|
|
|
|
2016-12-22 06:16:22 -05:00
|
|
|
if len(l:match) == 0
|
|
|
|
" Try the parsing pattern for parsing errors.
|
|
|
|
let l:match = matchlist(l:line, l:parsing_pattern)
|
|
|
|
endif
|
|
|
|
|
2016-09-09 17:25:26 -04:00
|
|
|
if len(l:match) == 0
|
2016-09-13 17:26:04 -04:00
|
|
|
continue
|
2016-09-08 19:23:26 -04:00
|
|
|
endif
|
|
|
|
|
2016-12-22 06:16:22 -05:00
|
|
|
let l:type = 'Error'
|
|
|
|
let l:text = l:match[3]
|
|
|
|
|
|
|
|
" Take the error type from the output if available.
|
|
|
|
if !empty(l:match[4])
|
|
|
|
let l:type = split(l:match[4], '/')[0]
|
|
|
|
let l:text .= ' [' . l:match[4] . ']'
|
|
|
|
endif
|
2016-09-09 17:25:26 -04:00
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
call add(l:output, {
|
2016-09-14 06:47:52 -04:00
|
|
|
\ 'bufnr': a:buffer,
|
2016-09-09 17:25:26 -04:00
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
2016-10-10 19:43:45 -04:00
|
|
|
\ 'text': l:text,
|
|
|
|
\ 'type': l:type ==# 'Warning' ? 'W' : 'E',
|
2016-09-08 19:23:26 -04:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
return l:output
|
2016-09-08 19:23:26 -04:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('javascript', {
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'name': 'eslint',
|
2016-10-23 08:04:41 -04:00
|
|
|
\ 'executable_callback': 'ale_linters#javascript#eslint#GetExecutable',
|
|
|
|
\ 'command_callback': 'ale_linters#javascript#eslint#GetCommand',
|
2016-09-08 19:23:26 -04:00
|
|
|
\ 'callback': 'ale_linters#javascript#eslint#Handle',
|
|
|
|
\})
|