2017-07-09 10:48:04 -04:00
|
|
|
" Author: ynonp - https://github.com/ynonp, Eddie Lebow https://github.com/elebow
|
|
|
|
" Description: RuboCop, a code style analyzer for Ruby files
|
2016-09-15 16:09:04 -04:00
|
|
|
|
2017-05-18 04:22:34 -04:00
|
|
|
function! ale_linters#ruby#rubocop#GetCommand(buffer) abort
|
2017-07-06 17:47:07 -04:00
|
|
|
let l:executable = ale#handlers#rubocop#GetExecutable(a:buffer)
|
2017-05-18 04:22:34 -04:00
|
|
|
let l:exec_args = l:executable =~? 'bundle$'
|
|
|
|
\ ? ' exec rubocop'
|
|
|
|
\ : ''
|
|
|
|
|
|
|
|
return ale#Escape(l:executable) . l:exec_args
|
2017-07-09 10:48:04 -04:00
|
|
|
\ . ' --format json --force-exclusion '
|
2017-05-18 04:22:34 -04:00
|
|
|
\ . ale#Var(a:buffer, 'ruby_rubocop_options')
|
|
|
|
\ . ' --stdin ' . bufname(a:buffer)
|
|
|
|
endfunction
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#ruby#rubocop#Handle(buffer, lines) abort
|
2017-07-09 10:48:04 -04:00
|
|
|
if len(a:lines) == 0
|
|
|
|
return []
|
|
|
|
endif
|
|
|
|
|
|
|
|
let l:errors = json_decode(a:lines[0])
|
2016-09-15 03:37:53 -04:00
|
|
|
|
2017-07-09 10:48:04 -04:00
|
|
|
let l:output = []
|
2016-09-15 03:37:53 -04:00
|
|
|
|
2017-07-09 10:48:04 -04:00
|
|
|
for l:error in l:errors['files'][0]['offenses']
|
|
|
|
let l:start_col = l:error['location']['column'] + 0
|
2016-10-10 19:43:45 -04:00
|
|
|
call add(l:output, {
|
2017-07-09 10:48:04 -04:00
|
|
|
\ 'lnum': l:error['location']['line'] + 0,
|
|
|
|
\ 'col': l:start_col,
|
|
|
|
\ 'end_col': l:start_col + l:error['location']['length'] - 1,
|
|
|
|
\ 'text': l:error['message'],
|
|
|
|
\ 'type': ale_linters#ruby#rubocop#GetType(l:error['severity']),
|
2016-09-15 03:37:53 -04:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
return l:output
|
2016-09-15 03:37:53 -04:00
|
|
|
endfunction
|
|
|
|
|
2017-07-09 10:48:04 -04:00
|
|
|
function! ale_linters#ruby#rubocop#GetType(severity) abort
|
|
|
|
if a:severity ==? 'refactor'
|
|
|
|
return 'W'
|
|
|
|
elseif a:severity ==? 'convention'
|
|
|
|
return 'W'
|
|
|
|
elseif a:severity ==? 'warning'
|
|
|
|
return 'W'
|
|
|
|
elseif a:severity ==? 'error'
|
|
|
|
return 'E'
|
|
|
|
elseif a:severity ==? 'fatal'
|
|
|
|
return 'E'
|
|
|
|
else
|
|
|
|
echo 'Rubocop offense type unrecognized by ALE: ' + a:severity
|
|
|
|
return ''
|
|
|
|
endif
|
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('ruby', {
|
2016-09-15 16:09:04 -04:00
|
|
|
\ 'name': 'rubocop',
|
2017-07-06 17:47:07 -04:00
|
|
|
\ 'executable_callback': 'ale#handlers#rubocop#GetExecutable',
|
2017-02-03 16:03:52 -05:00
|
|
|
\ 'command_callback': 'ale_linters#ruby#rubocop#GetCommand',
|
2016-09-15 03:37:53 -04:00
|
|
|
\ 'callback': 'ale_linters#ruby#rubocop#Handle',
|
|
|
|
\})
|