2016-10-03 14:55:55 -04:00
|
|
|
" Author: w0rp <devw0rp@gmail.com>
|
|
|
|
" Description: Lints sh files using bash -n
|
|
|
|
|
2016-09-15 15:20:41 -04:00
|
|
|
" This option can be changed to change the default shell when the shell
|
|
|
|
" cannot be taken from the hashbang line.
|
|
|
|
if !exists('g:ale_linters_sh_shell_default_shell')
|
2016-10-09 15:39:14 -04:00
|
|
|
let g:ale_linters_sh_shell_default_shell = fnamemodify($SHELL, ':t')
|
|
|
|
|
|
|
|
if g:ale_linters_sh_shell_default_shell ==# ''
|
|
|
|
let g:ale_linters_sh_shell_default_shell = 'bash'
|
|
|
|
endif
|
2016-09-15 15:20:41 -04:00
|
|
|
endif
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#sh#shell#GetExecutable(buffer) abort
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:banglines = getbufline(a:buffer, 1)
|
2016-09-15 15:20:41 -04:00
|
|
|
|
|
|
|
" Take the shell executable from the hashbang, if we can.
|
2016-10-10 19:43:45 -04:00
|
|
|
if len(l:banglines) == 1 && l:banglines[0] =~# '^#!'
|
2016-10-09 14:41:27 -04:00
|
|
|
" Remove options like -e, etc.
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:line = substitute(l:banglines[0], '--\?[a-zA-Z0-9]\+', '', 'g')
|
2016-10-09 14:41:27 -04:00
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
for l:possible_shell in ['bash', 'tcsh', 'csh', 'zsh', 'sh']
|
|
|
|
if l:line =~# l:possible_shell . '\s*$'
|
|
|
|
return l:possible_shell
|
2016-10-09 14:32:01 -04:00
|
|
|
endif
|
|
|
|
endfor
|
2016-09-15 15:20:41 -04:00
|
|
|
endif
|
|
|
|
|
2016-10-09 14:32:01 -04:00
|
|
|
return g:ale_linters_sh_shell_default_shell
|
2016-09-15 15:20:41 -04:00
|
|
|
endfunction
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#sh#shell#GetCommand(buffer) abort
|
2016-09-15 15:20:41 -04:00
|
|
|
return ale_linters#sh#shell#GetExecutable(a:buffer) . ' -n'
|
|
|
|
endfunction
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#sh#shell#Handle(buffer, lines) abort
|
2016-09-15 15:20:41 -04:00
|
|
|
" Matches patterns line the following:
|
|
|
|
"
|
|
|
|
" bash: line 13: syntax error near unexpected token `d'
|
|
|
|
" sh: 11: Syntax error: "(" unexpected
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:pattern = '^[^:]\+: \%(\w\+ \|\)\(\d\+\): \(.\+\)'
|
|
|
|
let l:output = []
|
2016-09-15 15:20:41 -04:00
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
for l:line in a:lines
|
|
|
|
let l:match = matchlist(l:line, l:pattern)
|
2016-09-15 15:20:41 -04:00
|
|
|
|
|
|
|
if len(l:match) == 0
|
|
|
|
continue
|
|
|
|
endif
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:line = l:match[1] + 0
|
|
|
|
let l:column = 1
|
|
|
|
let l:text = l:match[2]
|
|
|
|
let l:type = 'E'
|
2016-09-15 15:20:41 -04:00
|
|
|
|
|
|
|
" vcol is Needed to indicate that the column is a character.
|
2016-10-10 19:43:45 -04:00
|
|
|
call add(l:output, {
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'bufnr': a:buffer,
|
2016-10-10 19:43:45 -04:00
|
|
|
\ 'lnum': l:line,
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'vcol': 0,
|
2016-10-10 19:43:45 -04:00
|
|
|
\ 'col': l:column,
|
|
|
|
\ 'text': l:text,
|
|
|
|
\ 'type': l:type,
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'nr': -1,
|
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
return l:output
|
2016-09-15 15:20:41 -04:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('sh', {
|
2016-09-15 15:20:41 -04:00
|
|
|
\ 'name': 'shell',
|
|
|
|
\ 'output_stream': 'stderr',
|
|
|
|
\ 'executable_callback': 'ale_linters#sh#shell#GetExecutable',
|
|
|
|
\ 'command_callback': 'ale_linters#sh#shell#GetCommand',
|
|
|
|
\ 'callback': 'ale_linters#sh#shell#Handle',
|
|
|
|
\})
|