2018-04-09 11:45:08 -04:00
|
|
|
" Author: Johannes Wienke <languitar@semipol.de>
|
|
|
|
|
" Description: PMD for Java files
|
|
|
|
|
|
|
|
|
|
function! ale_linters#java#pmd#Handle(buffer, lines) abort
|
Fix PMD not working with classes without package
PMD is currently not working properly for Java classes that use [unnamed
packages](https://docs.oracle.com/javase/specs/jls/se11/html/jls-7.html#jls-7.4.2).
Consider the following Java class that does not contain a `package`
declaration:
```java
public class App {
String getGreeting() {
return "Hello world.";
}
static void main(String... args) {
System.out.println(new App().getGreeting());
}
}
```
Running PMD in the command line agaist the Java class above produces an
output with empty string `""` in the `"Package"` column:
```sh
$ pmd -R category/java/bestpractices.xml -f csv -d './src/main/java/App.java'
Oct 02, 2018 9:10:39 PM net.sourceforge.pmd.PMD processFiles
WARNING: This analysis could be faster, please consider using Incremental Analysis: https://pmd.github.io/pmd-6.7.0/pmd_userdocs_incremental_analysis.html
"Problem","Package","File","Priority","Line","Description","Rule set","Rule"
"1","","/Users/diego/Projects/github.com/dlresende/kata-fizz-buzz/src/main/java/App.java","2","7","System.out.println is used","Best Practices","SystemPrintln"
```
But the pmd.vim handler's current pattern refuses everything coming
from a Java class that does not have a package name (2nd column):
```vim
let l:pattern = '"\(\d\+\)",".\+","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
```
The solution I am proposing is to also accept empty strings as package names.
2018-10-02 16:05:14 -04:00
|
|
|
let l:pattern = '"\(\d\+\)",".*","\(.\+\)","\(\d\+\)","\(\d\+\)","\(.\+\)","\(.\+\)","\(.\+\)"$'
|
2018-04-09 11:45:08 -04:00
|
|
|
let l:output = []
|
|
|
|
|
|
|
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
|
|
|
|
call add(l:output, {
|
|
|
|
|
\ 'type': 'W',
|
|
|
|
|
\ 'lnum': l:match[4] + 0,
|
|
|
|
|
\ 'text': l:match[5],
|
|
|
|
|
\ 'code': l:match[6] . ' - ' . l:match[7],
|
|
|
|
|
\})
|
|
|
|
|
endfor
|
|
|
|
|
|
|
|
|
|
return l:output
|
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
|
|
function! ale_linters#java#pmd#GetCommand(buffer) abort
|
|
|
|
|
return 'pmd '
|
|
|
|
|
\ . ale#Var(a:buffer, 'java_pmd_options')
|
|
|
|
|
\ . ' -f csv'
|
|
|
|
|
\ . ' -d %t'
|
|
|
|
|
endfunction
|
|
|
|
|
|
|
|
|
|
if !exists('g:ale_java_pmd_options')
|
|
|
|
|
let g:ale_java_pmd_options = '-R category/java/bestpractices.xml'
|
|
|
|
|
endif
|
|
|
|
|
|
|
|
|
|
call ale#linter#Define('java', {
|
|
|
|
|
\ 'name': 'pmd',
|
|
|
|
|
\ 'executable': 'pmd',
|
|
|
|
|
\ 'command_callback': 'ale_linters#java#pmd#GetCommand',
|
|
|
|
|
\ 'callback': 'ale_linters#java#pmd#Handle',
|
|
|
|
|
\})
|