2017-06-21 16:35:40 -04:00
|
|
|
" Author: jwilliams108 <https://github.com/jwilliams108>, Eric Stern <https://github.com/firehed>
|
2016-10-06 05:11:19 -04:00
|
|
|
" Description: phpcs for PHP files
|
|
|
|
|
2017-04-15 20:24:08 -04:00
|
|
|
let g:ale_php_phpcs_standard = get(g:, 'ale_php_phpcs_standard', '')
|
2016-10-06 05:11:19 -04:00
|
|
|
|
2017-06-21 16:35:40 -04:00
|
|
|
call ale#Set('php_phpcs_executable', 'phpcs')
|
2018-04-09 14:11:20 -04:00
|
|
|
call ale#Set('php_phpcs_use_global', get(g:, 'ale_use_global_executables', 0))
|
2017-06-21 16:35:40 -04:00
|
|
|
|
|
|
|
function! ale_linters#php#phpcs#GetExecutable(buffer) abort
|
|
|
|
return ale#node#FindExecutable(a:buffer, 'php_phpcs', [
|
|
|
|
\ 'vendor/bin/phpcs',
|
|
|
|
\ 'phpcs'
|
|
|
|
\])
|
|
|
|
endfunction
|
|
|
|
|
2017-04-15 20:24:08 -04:00
|
|
|
function! ale_linters#php#phpcs#GetCommand(buffer) abort
|
2017-06-21 16:35:40 -04:00
|
|
|
let l:executable = ale_linters#php#phpcs#GetExecutable(a:buffer)
|
|
|
|
|
2017-04-15 20:24:08 -04:00
|
|
|
let l:standard = ale#Var(a:buffer, 'php_phpcs_standard')
|
|
|
|
let l:standard_option = !empty(l:standard)
|
|
|
|
\ ? '--standard=' . l:standard
|
|
|
|
\ : ''
|
2016-10-06 05:11:19 -04:00
|
|
|
|
2017-06-21 16:35:40 -04:00
|
|
|
return ale#Escape(l:executable)
|
|
|
|
\ . ' -s --report=emacs --stdin-path=%s ' . l:standard_option
|
2016-10-06 05:11:19 -04:00
|
|
|
endfunction
|
|
|
|
|
2017-01-22 09:54:57 -05:00
|
|
|
function! ale_linters#php#phpcs#Handle(buffer, lines) abort
|
2016-10-06 05:11:19 -04:00
|
|
|
" Matches against lines like the following:
|
|
|
|
"
|
|
|
|
" /path/to/some-filename.php:18:3: error - Line indented incorrectly; expected 4 spaces, found 2 (Generic.WhiteSpace.ScopeIndent.IncorrectExact)
|
2017-10-18 19:07:29 -04:00
|
|
|
let l:pattern = '^.*:\(\d\+\):\(\d\+\): \(.\+\) - \(.\+\) (\(.\+\))$'
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:output = []
|
2016-10-06 05:11:19 -04:00
|
|
|
|
2017-04-17 19:35:53 -04:00
|
|
|
for l:match in ale#util#GetMatches(a:lines, l:pattern)
|
2017-10-18 19:07:29 -04:00
|
|
|
let l:code = l:match[5]
|
|
|
|
let l:text = l:match[4] . ' (' . l:code . ')'
|
2016-10-10 19:43:45 -04:00
|
|
|
let l:type = l:match[3]
|
2016-10-06 05:11:19 -04:00
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
call add(l:output, {
|
2016-10-06 05:11:19 -04:00
|
|
|
\ 'lnum': l:match[1] + 0,
|
|
|
|
\ 'col': l:match[2] + 0,
|
2016-10-10 19:43:45 -04:00
|
|
|
\ 'text': l:text,
|
2017-08-08 03:39:13 -04:00
|
|
|
\ 'type': l:type is# 'error' ? 'E' : 'W',
|
2016-10-06 05:11:19 -04:00
|
|
|
\})
|
|
|
|
endfor
|
|
|
|
|
2016-10-10 19:43:45 -04:00
|
|
|
return l:output
|
2016-10-06 05:11:19 -04:00
|
|
|
endfunction
|
|
|
|
|
First pass at optimizing ale to autoload (#80)
* First pass at optimizing ale to autoload
First off, the structure/function names should be revised a bit,
but I will wait for @w0rp's input before unifying the naming style.
Second off, the docs probably need some more work, I just did some
simple find-and-replace work.
With that said, this pull brings major performance gains for ale. On my
slowest system, fully loading ale and all its code takes around 150ms.
I have moved all of ale's autoload-able code to autoload/, and in
addition, implemented lazy-loading of linters. This brings load time on
that same system down to 5ms.
The only downside of lazy loading is that `g:ale_linters` cannot be
changed at runtime; however, it also speeds up performance at runtime by
simplfying the logic greatly.
Please let me know what you think!
Closes #59
* Address Travis/Vint errors
For some reason, ale isn't running vint for me...
* Incorporate feedback, make fixes
Lazy-loading logic is much improved.
* Add header comments; remove incorrect workaround
* Remove unneeded plugin guards
* Fix lazy-loading linter logic
Set the wrong variable....
* Fix capitialization
2016-10-10 14:51:29 -04:00
|
|
|
call ale#linter#Define('php', {
|
2016-10-06 05:11:19 -04:00
|
|
|
\ 'name': 'phpcs',
|
2017-06-21 16:35:40 -04:00
|
|
|
\ 'executable_callback': 'ale_linters#php#phpcs#GetExecutable',
|
2016-10-06 05:11:19 -04:00
|
|
|
\ 'command_callback': 'ale_linters#php#phpcs#GetCommand',
|
|
|
|
\ 'callback': 'ale_linters#php#phpcs#Handle',
|
|
|
|
\})
|