ale/test/handler/test_eslint_handler.vader

368 lines
16 KiB
Plaintext
Raw Permalink Normal View History

2017-08-22 16:40:00 -04:00
Before:
Save g:ale_javascript_eslint_suppress_eslintignore
Save g:ale_javascript_eslint_suppress_missing_config
2017-08-22 16:40:00 -04:00
let g:ale_javascript_eslint_suppress_eslintignore = 0
let g:ale_javascript_eslint_suppress_missing_config = 0
2017-08-22 16:40:00 -04:00
After:
2017-08-22 16:40:00 -04:00
Restore
unlet! b:ale_javascript_eslint_suppress_eslintignore
unlet! b:ale_javascript_eslint_suppress_missing_config
unlet! g:config_error_lines
Execute(The eslint handler should parse lines correctly):
AssertEqual
\ [
\ {
\ 'lnum': 47,
\ 'col': 14,
2017-11-13 18:21:45 -05:00
\ 'text': 'Missing trailing comma.',
\ 'code': 'comma-dangle',
\ 'type': 'W',
\ },
\ {
\ 'lnum': 56,
\ 'col': 41,
2017-11-13 18:21:45 -05:00
\ 'text': 'Missing semicolon.',
\ 'code': 'semi',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 13,
\ 'col': 3,
\ 'text': 'Parsing error: Unexpected token',
\ 'type': 'E',
\ },
\ ],
\ ale#handlers#eslint#Handle(bufnr(''), [
\ 'This line should be ignored completely',
\ '/path/to/some-filename.js:47:14: Missing trailing comma. [Warning/comma-dangle]',
\ '/path/to/some-filename.js:56:41: Missing semicolon. [Error/semi]',
\ 'This line should be ignored completely',
\ '/path/to/some-filename.js:13:3: Parsing error: Unexpected token',
\ ])
Execute(The eslint handler should print a message about a missing configuration file):
let g:config_error_lines = [
\ '',
\ 'Oops! Something went wrong! :(',
\ '',
\ 'ESLint couldn''t find a configuration file. To set up a configuration file for this project, please run:',
\ ' eslint --init',
\ '',
\ 'ESLint looked for configuration files in /some/path/or/other and its ancestors.',
\ '',
\ 'If you think you already have a configuration file or if you need more help, please stop by the ESLint chat room: https://gitter.im/eslint/eslint',
\ '',
\ ]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(The eslint handler should allow the missing config error to be suppressed):
let b:ale_javascript_eslint_suppress_missing_config = 1
let g:config_error_lines = [
\ '',
\ 'Oops! Something went wrong! :(',
\ '',
\ 'ESLint couldn''t find a configuration file. To set up a configuration file for this project, please run:',
\ ' eslint --init',
\ '',
\ 'ESLint looked for configuration files in /some/path/or/other and its ancestors.',
\ '',
\ 'If you think you already have a configuration file or if you need more help, please stop by the ESLint chat room: https://gitter.im/eslint/eslint',
\ '',
\ ]
AssertEqual
\ [],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(The eslint handler should print a message for config parsing errors):
let g:config_error_lines = [
\ 'Cannot read config file: /some/path/or/other/.eslintrc.js',
\ 'Error: Unexpected token <<',
\ '/some/path/or/other/.eslintrc.js:1',
\ '(function (exports, require, module, __filename, __dirname) { <<<>>>',
\ ' ^^',
\ 'SyntaxError: Unexpected token <<',
\ ' at Object.exports.runInThisContext (vm.js:76:16)',
\ ' at Module._compile (module.js:528:28)',
\ ' at Object.Module._extensions..js (module.js:565:10)',
\ ' at Module.load (module.js:473:32)',
\ ' at tryModuleLoad (module.js:432:12)',
\ ' at Function.Module._load (module.js:424:3)',
\ ' at Module.require (module.js:483:17)',
\ ' at require (internal/module.js:20:19)',
\ ' at module.exports (/usr/local/lib/node_modules/eslint/node_modules/require-uncached/index.js:14:12)',
\ ' at loadJSConfigFile (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:160:16)',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(Suppressing missing configs shouldn't suppress parsing errors):
let b:ale_javascript_eslint_suppress_missing_config = 1
let g:config_error_lines = [
\ 'Cannot read config file: /some/path/or/other/.eslintrc.js',
\ 'Error: Unexpected token <<',
\ '/some/path/or/other/.eslintrc.js:1',
\ '(function (exports, require, module, __filename, __dirname) { <<<>>>',
\ ' ^^',
\ 'SyntaxError: Unexpected token <<',
\ ' at Object.exports.runInThisContext (vm.js:76:16)',
\ ' at Module._compile (module.js:528:28)',
\ ' at Object.Module._extensions..js (module.js:565:10)',
\ ' at Module.load (module.js:473:32)',
\ ' at tryModuleLoad (module.js:432:12)',
\ ' at Function.Module._load (module.js:424:3)',
\ ' at Module.require (module.js:483:17)',
\ ' at require (internal/module.js:20:19)',
\ ' at module.exports (/usr/local/lib/node_modules/eslint/node_modules/require-uncached/index.js:14:12)',
\ ' at loadJSConfigFile (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:160:16)',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(The eslint handler should print a message for invalid configuration settings):
let g:config_error_lines = [
\ '/home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ 'Error: /home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ ' at validateRuleOptions (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:115:15)',
\ ' at /usr/local/lib/node_modules/eslint/lib/config/config-validator.js:162:13',
\ ' at Array.forEach (native)',
\ ' at Object.validate (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:161:35)',
\ ' at Object.load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:522:19)',
\ ' at loadConfig (/usr/local/lib/node_modules/eslint/lib/config.js:63:33)',
\ ' at getLocalConfig (/usr/local/lib/node_modules/eslint/lib/config.js:130:29)',
\ ' at Config.getConfig (/usr/local/lib/node_modules/eslint/lib/config.js:256:22)',
\ ' at processText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:224:33)',
\ ' at CLIEngine.executeOnText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:756:26)',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(Suppressing missing configs shouldn't suppress invalid config errors):
let b:ale_javascript_eslint_suppress_missing_config = 1
let g:config_error_lines = [
\ '/home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ 'Error: /home/w0rp/git/wazoku/wazoku-spotlight/.eslintrc.js:',
\ ' Configuration for rule "indent" is invalid:',
\ ' Value "off" is the wrong type.',
\ '',
\ ' at validateRuleOptions (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:115:15)',
\ ' at /usr/local/lib/node_modules/eslint/lib/config/config-validator.js:162:13',
\ ' at Array.forEach (native)',
\ ' at Object.validate (/usr/local/lib/node_modules/eslint/lib/config/config-validator.js:161:35)',
\ ' at Object.load (/usr/local/lib/node_modules/eslint/lib/config/config-file.js:522:19)',
\ ' at loadConfig (/usr/local/lib/node_modules/eslint/lib/config.js:63:33)',
\ ' at getLocalConfig (/usr/local/lib/node_modules/eslint/lib/config.js:130:29)',
\ ' at Config.getConfig (/usr/local/lib/node_modules/eslint/lib/config.js:256:22)',
\ ' at processText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:224:33)',
\ ' at CLIEngine.executeOnText (/usr/local/lib/node_modules/eslint/lib/cli-engine.js:756:26)',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(The eslint handler should print a message when import is not used in a module):
let g:config_error_lines = [
\ 'ImportDeclaration should appear when the mode is ES6 and in the module context.',
\ 'AssertionError: ImportDeclaration should appear when the mode is ES6 and in the module context.',
\ ' at Referencer.ImportDeclaration (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/referencer.js:597:9)',
\ ' at Referencer.Visitor.visit (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:122:34)',
\ ' at Referencer.Visitor.visitChildren (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:101:38)',
\ ' at Referencer.Program (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/referencer.js:449:14)',
\ ' at Referencer.Visitor.visit (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:122:34)',
\ ' at Object.analyze (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/index.js:138:16)',
\ ' at EventEmitter.module.exports.api.verify (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/eslint.js:887:40)',
\ ' at processText (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli-engine.js:278:31)',
\ ' at CLIEngine.executeOnText (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli-engine.js:734:26)',
\ ' at Object.execute (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli.js:171:42) ',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(Suppressing missing configs shouldn't suppress module import errors):
let b:ale_javascript_eslint_suppress_missing_config = 1
let g:config_error_lines = [
\ 'ImportDeclaration should appear when the mode is ES6 and in the module context.',
\ 'AssertionError: ImportDeclaration should appear when the mode is ES6 and in the module context.',
\ ' at Referencer.ImportDeclaration (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/referencer.js:597:9)',
\ ' at Referencer.Visitor.visit (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:122:34)',
\ ' at Referencer.Visitor.visitChildren (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:101:38)',
\ ' at Referencer.Program (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/referencer.js:449:14)',
\ ' at Referencer.Visitor.visit (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/esrecurse/esrecurse.js:122:34)',
\ ' at Object.analyze (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint-scope/lib/index.js:138:16)',
\ ' at EventEmitter.module.exports.api.verify (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/eslint.js:887:40)',
\ ' at processText (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli-engine.js:278:31)',
\ ' at CLIEngine.executeOnText (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli-engine.js:734:26)',
\ ' at Object.execute (/home/w0rp/git/wazoku/wazoku-spotlight/spotlight/static/node_modules/eslint/lib/cli.js:171:42) ',
\]
AssertEqual
\ [{
\ 'lnum': 1,
\ 'text': 'eslint configuration error (type :ALEDetail for more information)',
\ 'detail': join(g:config_error_lines, "\n"),
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), g:config_error_lines[:])
Execute(The eslint handler should output end_col values where appropriate):
AssertEqual
\ [
\ {
\ 'lnum': 4,
\ 'col': 3,
\ 'end_col': 15,
2017-11-13 18:21:45 -05:00
\ 'text': 'Parsing error: Unexpected token ''some string''',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 70,
\ 'col': 3,
\ 'end_col': 5,
2017-11-13 18:21:45 -05:00
\ 'text': '''foo'' is not defined.',
\ 'code': 'no-undef',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 71,
\ 'col': 2,
\ 'end_col': 6,
2017-11-13 18:21:45 -05:00
\ 'text': 'Unexpected `await` inside a loop.',
\ 'code': 'no-await-in-loop',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 72,
\ 'col': 6,
\ 'end_col': 10,
2017-11-13 18:21:45 -05:00
\ 'text': 'Redundant use of `await` on a return value.',
\ 'code': 'no-return-await',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 73,
\ 'col': 4,
\ 'end_col': 10,
2017-11-13 18:21:45 -05:00
\ 'text': 'Unexpected console statement',
\ 'code': 'no-console',
\ 'type': 'E',
\ },
\ {
\ 'lnum': 74,
\ 'col': 4,
\ 'end_col': 11,
2017-11-13 18:21:45 -05:00
\ 'text': 'Unexpected ''debugger'' statement.',
\ 'code': 'no-debugger',
\ 'type': 'E',
\ },
\ ],
\ ale#handlers#eslint#Handle(bufnr(''), [
\ 'app.js:4:3: Parsing error: Unexpected token ''some string'' [Error]',
\ 'app.js:70:3: ''foo'' is not defined. [Error/no-undef]',
\ 'app.js:71:2: Unexpected `await` inside a loop. [Error/no-await-in-loop]',
\ 'app.js:72:6: Redundant use of `await` on a return value. [Error/no-return-await]',
\ 'app.js:73:4: Unexpected console statement [Error/no-console]',
\ 'app.js:74:4: Unexpected ''debugger'' statement. [Error/no-debugger]',
\ ])
Execute(The eslint hint about using typescript-eslint-parser):
silent! noautocmd file foo.ts
AssertEqual
\ [
\ {
\ 'lnum': 451,
\ 'col': 2,
\ 'end_col': 2,
2017-11-13 18:21:45 -05:00
\ 'text': 'Parsing error (You may need configure typescript-eslint-parser): Unexpected token )',
\ 'type': 'E',
\ },
\ ],
\ ale#handlers#eslint#Handle(bufnr(''), [
\ 'foo.ts:451:2: Parsing error: Unexpected token ) [Error]',
\ ])
2017-08-22 16:40:00 -04:00
Execute(eslint should warn about ignored files by default):
AssertEqual
\ [{
\ 'lnum': 0,
\ 'col': 0,
\ 'type': 'W',
2017-11-13 18:21:45 -05:00
\ 'text': 'File ignored because of a matching ignore pattern. Use "--no-ignore" to override.'
2017-08-22 16:40:00 -04:00
\ }],
\ ale#handlers#eslint#Handle(bufnr(''), [
2017-08-22 16:40:00 -04:00
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])
Execute(eslint should not warn about ignored files when explicitly disabled):
let g:ale_javascript_eslint_suppress_eslintignore = 1
AssertEqual
\ [],
\ ale#handlers#eslint#Handle(bufnr(''), [
2017-08-22 16:40:00 -04:00
\ '/path/to/some/ignored.js:0:0: File ignored because of a matching ignore pattern. Use "--no-ignore" to override. [Warning]',
\ ])
Execute(eslint should handle react errors correctly):
AssertEqual
\ [
\ {
\ 'lnum': 59,
\ 'col': 9,
\ 'type': 'E',
\ 'text': 'Property should be placed on the same line as the component declaration',
\ 'code': 'react/jsx-first-prop-new-line',
\ },
\ ],
\ ale#handlers#eslint#Handle(bufnr(''), [
\ '/path/editor-help.jsx:59:9: Property should be placed on the same line as the component declaration [Error/react/jsx-first-prop-new-line]',
\ ])