f500ecaffb
If the user had code like "foo.bar" and then entered insert mode after the 'r' in "bar", YCM would cause vim to hang. The problem happened because a sorting task was created that would try to sort on the latest clang result but none would be created because a clang task was not created in this occasion. clang_data_ready_ would remain false and would never be set to true, thus causing an infinite loop in SortingThreadMain since the thread would forever wait on the mutex. This was rectified with better handling of the clang results cache. Now the cache is a full class and it also stores the line & column number of the location for which the results were computed. Better logic is in place for the cache invalidation.
46 lines
1.4 KiB
C++
46 lines
1.4 KiB
C++
// Copyright (C) 2011, 2012 Strahinja Val Markovic <val@markovic.io>
|
|
//
|
|
// This file is part of YouCompleteMe.
|
|
//
|
|
// YouCompleteMe is free software: you can redistribute it and/or modify
|
|
// it under the terms of the GNU General Public License as published by
|
|
// the Free Software Foundation, either version 3 of the License, or
|
|
// (at your option) any later version.
|
|
//
|
|
// YouCompleteMe is distributed in the hope that it will be useful,
|
|
// but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
// GNU General Public License for more details.
|
|
//
|
|
// You should have received a copy of the GNU General Public License
|
|
// along with YouCompleteMe. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
#include "ClangResultsCache.h"
|
|
#include "standard.h"
|
|
|
|
using boost::shared_mutex;
|
|
using boost::shared_lock;
|
|
using boost::unique_lock;
|
|
|
|
namespace YouCompleteMe
|
|
{
|
|
|
|
bool ClangResultsCache::NewPositionDifferentFromStoredPosition( int new_line,
|
|
int new_colum )
|
|
const
|
|
{
|
|
shared_lock< shared_mutex > reader_lock( access_mutex_ );
|
|
return line_ != new_line || column_ != new_colum;
|
|
}
|
|
|
|
void ClangResultsCache::ResetWithNewLineAndColumn( int new_line, int new_colum )
|
|
{
|
|
unique_lock< shared_mutex > reader_lock( access_mutex_ );
|
|
|
|
line_ = new_line;
|
|
column_ = new_colum;
|
|
completion_datas_.clear();
|
|
}
|
|
|
|
} // namespace YouCompleteMe
|