YouCompleteMe/python/ycm
zzbot 7d72519039
Auto merge of #2978 - micbou:fix-filetype-specific-completion-to-disable, r=puremourning
[READY] Do not disable omnifunc when filetype completion is disabled

Prior to PR https://github.com/Valloric/YouCompleteMe/pull/2657, it was possible to trigger Vim's omnifunc with `<C-Space>` even if semantic completion was disabled for the current filetype through the `g:ycm_filetype_specific_completion_to_disable` option. It worked because `<C-Space>` was mapped to `<C-X><C-O><C-P>`, which are the keys to trigger the omnifunc. PR https://github.com/Valloric/YouCompleteMe/pull/2657 changed that by making `<C-Space>` directly call the `SendCompletionRequest` function with `force_semantic` sets to `True`. This change was necessary to get fuzzy matching with the omnifunc (see issue https://github.com/Valloric/YouCompleteMe/issues/961) but broke the `<C-Space>` behavior when filetype completion is disabled. This PR restores that behavior.

Fixes https://github.com/Valloric/YouCompleteMe/issues/2950.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2978)
<!-- Reviewable:end -->
2018-04-14 12:32:46 -07:00
..
client Auto merge of #2976 - micbou:refactor-server-exception-handling, r=puremourning 2018-04-14 11:13:15 -07:00
tests Auto merge of #2978 - micbou:fix-filetype-specific-completion-to-disable, r=puremourning 2018-04-14 12:32:46 -07:00
__init__.py Fixing python tests broken in rename 2013-05-19 20:06:14 -07:00
base.py Rewrite completion system 2017-06-21 02:32:57 +02:00
buffer.py Improve diagnostic matches display 2018-02-18 21:32:00 +01:00
diagnostic_filter.py Do not install aliases from future 2017-03-18 18:24:48 +01:00
diagnostic_interface.py Improve diagnostic matches display 2018-02-18 21:32:00 +01:00
omni_completer.py Auto merge of #2978 - micbou:fix-filetype-specific-completion-to-disable, r=puremourning 2018-04-14 12:32:46 -07:00
paths.py Drop Python 2.6 and Python 3.3 2018-01-30 18:34:50 +01:00
setup.py Add error messages when ycmd crashed 2016-05-02 23:08:32 +02:00
syntax_parse.py Add function to capture Vim command output 2018-02-18 14:06:09 +01:00
unsafe_thread_pool_executor.py Update flake8 config 2016-03-06 17:39:55 +00:00
vimsupport.py Do not disable omnifunc when filetype completion is disabled 2018-04-13 02:40:50 +02:00
youcompleteme.py Auto merge of #2978 - micbou:fix-filetype-specific-completion-to-disable, r=puremourning 2018-04-14 12:32:46 -07:00