From fe94ed6b1c3586c3d61acab505c7e7b3af65172c Mon Sep 17 00:00:00 2001 From: Strahinja Val Markovic Date: Tue, 1 Oct 2013 10:41:34 -0700 Subject: [PATCH] Removing an outdate TODO --- python/ycm/vimsupport.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/python/ycm/vimsupport.py b/python/ycm/vimsupport.py index bb2e20ec..78047003 100644 --- a/python/ycm/vimsupport.py +++ b/python/ycm/vimsupport.py @@ -99,11 +99,10 @@ def NumLinesInBuffer( buffer_object ): return len( buffer_object ) +# Calling this function from the non-GUI thread will sometimes crash Vim. At the +# time of writing, YCM only uses the GUI thread inside Vim (this used to not be +# the case). def PostVimMessage( message ): - # TODO: Check are we on the main thread or not, and if not, force a crash - # here. This should make it impossible to accidentally call this from a - # non-GUI thread which *sometimes* crashes Vim because Vim is not thread-safe. - # A consistent crash should force us to notice the error. vim.command( "echohl WarningMsg | echomsg '{0}' | echohl None" .format( EscapeForVim( str( message ) ) ) )