vim/YouCompleteMe
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Auto merge of #2697 - bstaletic:readme_fix, r=micbou

Browse Source 
Correct vim 7.4 patch requirement

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [ ] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.
- [x] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful

[Please explain **in detail** why the changes in this PR are needed.]

With Valloric/YouCompleteMe#2636 we bumped minimum required vim version to 7.4.1578, but in one place we didn't change the value.

Yes, this PR is just one number change, but inconsitency bothers me.

[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2697)
<!-- Reviewable:end -->
This commit is contained in:
zzbot 2017-06-28 18:31:29 -07:00 committed by GitHub
commit b564b5d8e3
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -524,7 +524,7 @@ process.
it should say `Vi IMproved X.Y`, where X.Y is the major version of vim. If it should say `Vi IMproved X.Y`, where X.Y is the major version of vim. If
your version is greater than 7.4, then you're all set. If your version is your version is greater than 7.4, then you're all set. If your version is
7.4 then look below that where it says, `Included patches: 1-Z`, where Z 7.4 then look below that where it says, `Included patches: 1-Z`, where Z
will be some number. That number needs to be 143 or higher. will be some number. That number needs to be 1578 or higher.
If your version of Vim is not recent enough, you may need to [compile Vim If your version of Vim is not recent enough, you may need to [compile Vim
from source][vim-build] (don't worry, it's easy). from source][vim-build] (don't worry, it's easy).

2
doc/youcompleteme.txt
View File

@ -739,7 +739,7 @@ will notify you to recompile it. You should then rerun the install process.
output; it should say 'Vi IMproved X.Y', where X.Y is the major version output; it should say 'Vi IMproved X.Y', where X.Y is the major version
of vim. If your version is greater than 7.4, then you're all set. If your of vim. If your version is greater than 7.4, then you're all set. If your
version is 7.4 then look below that where it says, 'Included patches: version is 7.4 then look below that where it says, 'Included patches:
1-Z', where Z will be some number. That number needs to be 143 or higher. 1-Z', where Z will be some number. That number needs to be 1578 or higher.
If your version of Vim is not recent enough, you may need to compile Vim If your version of Vim is not recent enough, you may need to compile Vim
from source [30] (don't worry, it's easy). from source [30] (don't worry, it's easy).