vim/YouCompleteMe
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Auto merge of #2994 - micbou:fix-should-resend, r=puremourning

Browse Source 
[READY] Fix resending request when buffer is not yet parsed

Fixes https://github.com/Valloric/YouCompleteMe/issues/2993.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2994)
<!-- Reviewable:end -->
This commit is contained in:
zzbot 2018-04-23 14:35:42 -07:00 committed by GitHub
commit 84554d2194
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
python/ycm/buffer.py
View File

@ -67,7 +67,7 @@ class Buffer( object ):
def ShouldResendParseRequest( self ): def ShouldResendParseRequest( self ):
return self._parse_request.ShouldResend() return bool( self._parse_request and self._parse_request.ShouldResend() )
def UpdateDiagnostics( self, force=False ): def UpdateDiagnostics( self, force=False ):

7
python/ycm/tests/youcompleteme_test.py
View File

@ -1058,3 +1058,10 @@ def YouCompleteMe_OnCompleteDone_NoCompletionRequest_test( ycm,
on_complete_done ): on_complete_done ):
ycm.OnCompleteDone() ycm.OnCompleteDone()
on_complete_done.assert_not_called() on_complete_done.assert_not_called()
@YouCompleteMeInstance()
def YouCompleteMe_ShouldResendFileParseRequest_NoParseRequest_test( ycm ):
current_buffer = VimBuffer( 'current_buffer' )
with MockVimBuffers( [ current_buffer ], current_buffer ):
assert_that( ycm.ShouldResendFileParseRequest(), equal_to( False ) )