Adding -Wextra and fixing warnings from it

cpp/CMakeLists.txt

@@ -86,8 +86,7 @@ endif()
 
 if( CMAKE_COMPILER_IS_GNUCXX OR COMPILER_IS_CLANG )
   # We want all warnings, and warnings should be treated as errors
-	# TODO: -Wextra?
+  add_definitions( -Wall -Wextra -Werror )
-  add_definitions( -Wall -Werror )
 endif()
 
 add_subdirectory( tests )

cpp/Candidate.cpp

@@ -33,7 +33,7 @@ std::string GetWordBoundaryChars( const std::string &text )
 {
   std::string result;
 
-  for ( int i = 0; i < text.size(); ++i )
+  for ( uint i = 0; i < text.size(); ++i )
   {
     if ( i == 0 ||
          IsUppercase( text[ i ] ) ||

cpp/LetterHash.cpp

@@ -16,6 +16,7 @@
 // along with YouCompleteMe.  If not, see <http://www.gnu.org/licenses/>.
 
 #include "LetterHash.h"
+#include "standard.h"
 
 namespace YouCompleteMe
 {
@@ -45,7 +46,7 @@ LetterHash::LetterHash()
 {
 	letters_.resize( kNumLetters );
 
-	for ( int i = 0; i < letters_.size(); ++i )
+	for ( uint i = 0; i < letters_.size(); ++i )
 	{
 		letters_[ i ] = NULL;
 	}
@@ -54,7 +55,7 @@ LetterHash::LetterHash()
 
 LetterHash::~LetterHash()
 {
-	for ( int i = 0; i < letters_.size(); ++i )
+	for ( uint i = 0; i < letters_.size(); ++i )
 	{
 	  delete letters_[ i ];
 	}

cpp/LetterNode.cpp

@@ -15,8 +15,8 @@
 // You should have received a copy of the GNU General Public License
 // along with YouCompleteMe.  If not, see <http://www.gnu.org/licenses/>.
 
-#include "standard.h"
 #include "LetterNode.h"
+#include "standard.h"
 
 
 namespace YouCompleteMe
@@ -36,7 +36,7 @@ LetterNode::LetterNode( const std::string &text )
 
   letternode_per_text_index_.resize( text.size() );
 
-  for (int i = 0; i < text.size(); ++i)
+  for ( uint i = 0; i < text.size(); ++i)
   {
     char letter = text[ i ];
     LetterNode *node = new LetterNode( letter );
@@ -44,7 +44,8 @@ LetterNode::LetterNode( const std::string &text )
     letternode_per_text_index_[ i ] = boost::shared_ptr< LetterNode >( node );
   }
 
-  for ( int i = letternode_per_text_index_.size() - 1; i >= 0; --i )
+  for ( int i = static_cast< int >( letternode_per_text_index_.size() ) - 1;
+        i >= 0; --i )
   {
     LetterNode *node_to_add = letternode_per_text_index_[ i ].get();
 

cpp/Result.cpp

@@ -16,6 +16,7 @@
 // along with YouCompleteMe.  If not, see <http://www.gnu.org/licenses/>.
 
 #include "Result.h"
+#include "standard.h"
 #include "Utils.h"
 #include <boost/algorithm/string.hpp>
 
@@ -30,8 +31,8 @@ namespace
 int NumWordBoundaryCharMatches( const std::string &query,
                                 const std::string &word_boundary_chars )
 {
-  int i = 0;
+  uint i = 0;
-  int j = 0;
+  uint j = 0;
   while ( j < query.size() && i < word_boundary_chars.size() )
   {
     if ( toupper( query[ j ] ) == toupper( word_boundary_chars[ i ] ) )

cpp/standard.h

@@ -20,3 +20,11 @@
 // We're most definitely not going to use
 // it as BOOST_FOREACH.
 #define foreach BOOST_FOREACH
+
+
+namespace YouCompleteMe
+{
+
+typedef unsigned int uint;
+
+} // namespace YouCompleteMe