vim/YouCompleteMe
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Auto merge of #2584 - mikeperri:typescript-diagnostics, r=micbou

Browse Source 
Typescript diagnostics

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [x] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.
- [x] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful
This just makes use of [these changes](https://github.com/Valloric/ycmd/pull/718) to ycmd.
It adds TypeScript to the list of filetypes that diagnostics are supported for and reflects that in the README. (And updates ycmd.)
No tests are included, since the only code that changed is the hard-coded list of filetypes. The new ycmd functionality is tested in that project.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2584)
<!-- Reviewable:end -->
This commit is contained in:
Homu 2017-03-26 01:14:25 +09:00
commit 53e4de0e36
3 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -729,6 +729,7 @@ Quick Feature Summary
### TypeScript ### TypeScript
* Semantic auto-completion * Semantic auto-completion
* Real-time diagnostic display
* Renaming symbols (`RefactorRename <new name>`) * Renaming symbols (`RefactorRename <new name>`)
* Go to definition, find references (`GoToDefinition`, `GoToReferences`) * Go to definition, find references (`GoToDefinition`, `GoToReferences`)
* Semantic type information for identifiers (`GetType`) * Semantic type information for identifiers (`GetType`)
@ -1131,9 +1132,10 @@ Completer API.
### Diagnostic Display ### Diagnostic Display
YCM will display diagnostic notifications for C-family and C# languages if you YCM will display diagnostic notifications for C-family and C# languages if you
compiled YCM with Clang and Omnisharp support, respectively. Since YCM continuously compiled YCM with Clang and Omnisharp support, respectively. Diagnostics will
recompiles your file as you type, you'll get notified of errors and warnings also be displayed for TypeScript. Since YCM continuously recompiles your file as
in your file as fast as possible. you type, you'll get notified of errors and warnings in your file as fast as
possible.
Here are the various pieces of the diagnostic UI: Here are the various pieces of the diagnostic UI:

3
python/ycm/youcompleteme.py
View File

@ -100,7 +100,8 @@ CORE_OUTDATED_MESSAGE = (
'YCM core library too old; PLEASE RECOMPILE by running the install.py ' 'YCM core library too old; PLEASE RECOMPILE by running the install.py '
'script. See the documentation for more details.' ) 'script. See the documentation for more details.' )
SERVER_IDLE_SUICIDE_SECONDS = 10800 # 3 hours SERVER_IDLE_SUICIDE_SECONDS = 10800 # 3 hours
DIAGNOSTIC_UI_FILETYPES = set( [ 'cpp', 'cs', 'c', 'objc', 'objcpp' ] ) DIAGNOSTIC_UI_FILETYPES = set( [ 'cpp', 'cs', 'c', 'objc', 'objcpp',
'typescript' ] )
CLIENT_LOGFILE_FORMAT = 'ycm_' CLIENT_LOGFILE_FORMAT = 'ycm_'
SERVER_LOGFILE_FORMAT = 'ycmd_{port}_{std}_' SERVER_LOGFILE_FORMAT = 'ycmd_{port}_{std}_'

2
third_party/ycmd vendored

@ -1 +1 @@
Subproject commit fc7620a8a8b3880726c81b6b4e1789d8d25e38b6 Subproject commit 13da3d47255d559308b946242e508d3531dabda5