Rename method for clarity and tweak style

python/ycm/diagnostic_filter.py

@@ -46,8 +46,8 @@ class DiagnosticFilter( object ):
           self._filters.append( fn )
 
 
-  def Accept( self, diagnostic ):
+  def IsAllowed( self, diagnostic ):
-    # NB: we Accept() the diagnostic ONLY if
+    # NOTE: a diagnostic IsAllowed() ONLY if
     #  no filters match it
     for f in self._filters:
       if f( diagnostic ):
@@ -105,5 +105,5 @@ def _CompileLevel( level ):
   return FilterLevel
 
 
-FILTER_COMPILERS  = { 'regex'      : _CompileRegex,
+FILTER_COMPILERS  = { 'regex' : _CompileRegex,
-                      'level'      : _CompileLevel }
+                      'level' : _CompileLevel }

python/ycm/diagnostic_interface.py

@@ -70,7 +70,7 @@ class DiagnosticInterface( object ):
             self._user_options,
             vimsupport.CurrentFiletypes() )
     normalized_diags = [ _NormalizeDiagnostic( x ) for x in diags
-            if diag_filter.Accept(x) ]
+            if diag_filter.IsAllowed( x ) ]
     self._buffer_number_to_line_to_diags = _ConvertDiagListToDict(
         normalized_diags )
 

python/ycm/tests/diagnostic_filter_tests.py

@@ -34,7 +34,7 @@ def _assert_accept_equals( filter, text_or_obj, expected ):
   if not isinstance( text_or_obj, dict ):
     text_or_obj = { 'text': text_or_obj }
 
-  assert_that( filter.Accept( text_or_obj ), equal_to( expected ) )
+  assert_that( filter.IsAllowed( text_or_obj ), equal_to( expected ) )
 
 
 def _assert_accepts( filter, text ):