vim/YouCompleteMe
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Auto merge of #3388 - smeredith:patch-1, r=micbou

Browse Source 
Specify python3 in the README

If the user has both python 2 and 3, and 2 is the configured alternative, the instructions will fail with missing headers. This change makes it clear that python3 is needed for this step (because a previous step installed python3-dev.)

# PR Prelude

Thank you for working on YCM! :)

**Please complete these steps and check these boxes (by putting an `x` inside
the brackets) _before_ filing your PR:**

- [x] I have read and understood YCM's [CONTRIBUTING][cont] document.
- [x] I have read and understood YCM's [CODE_OF_CONDUCT][code] document.
- [x] I have included tests for the changes in my PR. If not, I have included a
  rationale for why I haven't.
- [x] **I understand my PR may be closed if it becomes obvious I didn't
  actually perform all of these steps.**

# Why this change is necessary and useful

If the user has both python 2 and 3, and 2 is the configured alternative, the instructions will fail with missing headers. This change makes it clear that python3 is needed for this step (because a previous step installed python3-dev.)

README.md change only--no tests needed.
I successfully followed the instructions with the new command.

[Please explain **in detail** why the changes in this PR are needed.]

[cont]: https://github.com/Valloric/YouCompleteMe/blob/master/CONTRIBUTING.md
[code]: https://github.com/Valloric/YouCompleteMe/blob/master/CODE_OF_CONDUCT.md

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/3388)
<!-- Reviewable:end -->
This commit is contained in:
zzbot 2019-05-06 04:15:45 -07:00 committed by GitHub
commit 29f7acf068
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
README.md
View File

@ -281,13 +281,13 @@ Compiling YCM **with** semantic support for C-family languages through
**libclang**: **libclang**:
cd ~/.vim/bundle/YouCompleteMe cd ~/.vim/bundle/YouCompleteMe
./install.py --clang-completer python3 install.py --clang-completer
Compiling YCM **with** semantic support for C-family languages through Compiling YCM **with** semantic support for C-family languages through
**experimental clangd**: **experimental clangd**:
cd ~/.vim/bundle/YouCompleteMe cd ~/.vim/bundle/YouCompleteMe
./install.py --clangd-completer python3 install.py --clangd-completer
Note that you can install YCM with both **libclang** and **clangd** enabled. In Note that you can install YCM with both **libclang** and **clangd** enabled. In
that case **clangd** will be preferred unless you have the following in your that case **clangd** will be preferred unless you have the following in your