Moving a comment closer to the related code
This commit is contained in:
parent
85d034f3e0
commit
04991d874d
@ -45,6 +45,14 @@ class ClangCompleter( Completer ):
|
|||||||
|
|
||||||
|
|
||||||
def GetUnsavedFilesVector( self ):
|
def GetUnsavedFilesVector( self ):
|
||||||
|
# CAREFUL HERE! For UnsavedFile filename and contents we are referring
|
||||||
|
# directly to Python-allocated and -managed memory since we are accepting
|
||||||
|
# pointers to data members of python objects. We need to ensure that those
|
||||||
|
# objects outlive our UnsavedFile objects. This is why we need the
|
||||||
|
# contents_holder and filename_holder lists, to make sure the string objects
|
||||||
|
# are still around when we call CandidatesForQueryAndLocationInFile. We do
|
||||||
|
# this to avoid an extra copy of the entire file contents.
|
||||||
|
|
||||||
files = ycm_core.UnsavedFileVec()
|
files = ycm_core.UnsavedFileVec()
|
||||||
self.contents_holder = []
|
self.contents_holder = []
|
||||||
self.filename_holder = []
|
self.filename_holder = []
|
||||||
@ -76,14 +84,6 @@ class ClangCompleter( Completer ):
|
|||||||
|
|
||||||
# TODO: sanitize query
|
# TODO: sanitize query
|
||||||
|
|
||||||
# CAREFUL HERE! For UnsavedFile filename and contents we are referring
|
|
||||||
# directly to Python-allocated and -managed memory since we are accepting
|
|
||||||
# pointers to data members of python objects. We need to ensure that those
|
|
||||||
# objects outlive our UnsavedFile objects. This is why we need the
|
|
||||||
# contents_holder and filename_holder lists, to make sure the string objects
|
|
||||||
# are still around when we call CandidatesForQueryAndLocationInFile. We do
|
|
||||||
# this to avoid an extra copy of the entire file contents.
|
|
||||||
|
|
||||||
files = ycm_core.UnsavedFileVec()
|
files = ycm_core.UnsavedFileVec()
|
||||||
if not query:
|
if not query:
|
||||||
files = self.GetUnsavedFilesVector()
|
files = self.GetUnsavedFilesVector()
|
||||||
|
Loading…
Reference in New Issue
Block a user