From fdba3ee393d6e6a91d772f4277a0314e88ff4d3d Mon Sep 17 00:00:00 2001 From: Piro / YUKI Hiroshi Date: Sat, 11 Jun 2016 16:22:31 +0900 Subject: [PATCH 1/8] Always disable dragging of the tab bar (to drag the window itself) if it is not on top #1134 --- content/treestyletab/treestyletab.css | 3 ++- history.en.md | 1 + history.ja.md | 1 + 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/content/treestyletab/treestyletab.css b/content/treestyletab/treestyletab.css index ed04eb82..99dc0411 100644 --- a/content/treestyletab/treestyletab.css +++ b/content/treestyletab/treestyletab.css @@ -422,9 +422,10 @@ toolbar.treestyletab-tabbar-toolbar-ready:not([nowindowdrag="true"]), .treestyletab-tabbar-toolbar:not([treestyletab-tabbar-position="top"]), .treestyletab-tabbar-toolbar[treestyletab-tabbar-position="top"]:not([treestyletab-tabbar-fixed="true"]) { appearance: none !important; - -moz-appearance: none !important; + -moz-appearance: none !important line-height: 0 !important; /* to avoid an useless space above the tab bar */ position: fixed !important; + -moz-window-dragging: default !important; } .treestyletab-tabbar-toolbar:not([treestyletab-tabbar-position="top"]) .tabbrowser-tabs, diff --git a/history.en.md b/history.en.md index fe4a4dce..a508be76 100644 --- a/history.en.md +++ b/history.en.md @@ -1,6 +1,7 @@ # History - master/HEAD + * Scrollbar in the tab bar couldn't operated by mouse if you show the menu bar, at Firefox 47 on Windows. * Better compatibility with the "Dark" theme of Firefox Developer Edition. * Better compatibility with FireGestures. * The width of expanded tab bar isn't enlarged too much, when shrunken tab bar is going to be wider than expanded tab bar. diff --git a/history.ja.md b/history.ja.md index 7e46ad43..2d9a1463 100644 --- a/history.ja.md +++ b/history.ja.md @@ -1,6 +1,7 @@ # 更新履歴 - master/HEAD + * Firefox 47で、Windowsにおいてメニューバーを表示するとタブバー内のスクロールバーをマウスで操作できなくなる問題を修正 * Firefox Developer EditionのDarkテーマとの互換性を向上 * FireGesturesとの互換性を向上 * 縮められたタブバーの幅を変更するときに、展開されたタブバーの幅が異常に大きくなることがあったのを修正 From 6a408401eb4dc112b5640106641800a2be104685 Mon Sep 17 00:00:00 2001 From: "YUKI \"Piro\" Hiroshi" Date: Sat, 11 Jun 2016 22:28:16 +0900 Subject: [PATCH 2/8] Add comparison of good and not good reports --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 523e0cb8..74f1e2e1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -9,6 +9,7 @@ This is possibly a generic guideline for contributing any Firefox addon project A good report is the fastest way to solve a problem. Even if the problem is very clear for you, possibly unclear for me. Unclear report can be left unfixed for long time. +You'll see an example of [good report](https://github.com/piroor/treestyletab/issues/1134) and [another report with too less information](https://github.com/piroor/treestyletab/issues/1135). Here is a list of typical questions I asked to existing reports: From e876fd08bc1b780382bd84ce1caa9114cefc64ef Mon Sep 17 00:00:00 2001 From: "YUKI \"Piro\" Hiroshi" Date: Sat, 11 Jun 2016 22:33:02 +0900 Subject: [PATCH 3/8] Add basic steps to reproduce --- ISSUE_TEMPLATE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md index 9181f33f..4e1dc163 100644 --- a/ISSUE_TEMPLATE.md +++ b/ISSUE_TEMPLATE.md @@ -7,9 +7,10 @@ https://github.com/piroor/treestyletab/blob/master/CONTRIBUTING.md ## Steps to reproduce - 1. - 2. + 1. Start Filrefox with clean profile. + 2. Install TST. 3. + 4. ## Expected result From cb3e3f7ff2f99f21f6d576dbc85f510cfd0abb76 Mon Sep 17 00:00:00 2001 From: Piro / YUKI Hiroshi Date: Sat, 11 Jun 2016 23:44:20 +0900 Subject: [PATCH 4/8] Fix missing semicolon --- content/treestyletab/treestyletab.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/treestyletab/treestyletab.css b/content/treestyletab/treestyletab.css index 99dc0411..b9583ea1 100644 --- a/content/treestyletab/treestyletab.css +++ b/content/treestyletab/treestyletab.css @@ -422,7 +422,7 @@ toolbar.treestyletab-tabbar-toolbar-ready:not([nowindowdrag="true"]), .treestyletab-tabbar-toolbar:not([treestyletab-tabbar-position="top"]), .treestyletab-tabbar-toolbar[treestyletab-tabbar-position="top"]:not([treestyletab-tabbar-fixed="true"]) { appearance: none !important; - -moz-appearance: none !important + -moz-appearance: none !important; line-height: 0 !important; /* to avoid an useless space above the tab bar */ position: fixed !important; -moz-window-dragging: default !important; From d29bcea6c334cbdb9d830036c30ab858e3b59f5b Mon Sep 17 00:00:00 2001 From: YUKI Hiroshi Date: Wed, 15 Jun 2016 14:25:42 +0900 Subject: [PATCH 5/8] Add news topics --- history.en.md | 1 + history.ja.md | 1 + 2 files changed, 2 insertions(+) diff --git a/history.en.md b/history.en.md index a508be76..a7db90bb 100644 --- a/history.en.md +++ b/history.en.md @@ -2,6 +2,7 @@ - master/HEAD * Scrollbar in the tab bar couldn't operated by mouse if you show the menu bar, at Firefox 47 on Windows. + * The tab bar was wrongly fixed to "overflowed" state after you shrink the tab bar too narrow. * Better compatibility with the "Dark" theme of Firefox Developer Edition. * Better compatibility with FireGestures. * The width of expanded tab bar isn't enlarged too much, when shrunken tab bar is going to be wider than expanded tab bar. diff --git a/history.ja.md b/history.ja.md index 2d9a1463..6c365fe7 100644 --- a/history.ja.md +++ b/history.ja.md @@ -2,6 +2,7 @@ - master/HEAD * Firefox 47で、Windowsにおいてメニューバーを表示するとタブバー内のスクロールバーをマウスで操作できなくなる問題を修正 + * タブバーの幅を極端に縮めた後、タブバーがoverflowの状態のままになることがあったのを修正 * Firefox Developer EditionのDarkテーマとの互換性を向上 * FireGesturesとの互換性を向上 * 縮められたタブバーの幅を変更するときに、展開されたタブバーの幅が異常に大きくなることがあったのを修正 From 14c38a6e74d98ce95e8c70b9e8de4e07ea0d0ebd Mon Sep 17 00:00:00 2001 From: YUKI Hiroshi Date: Wed, 15 Jun 2016 14:25:56 +0900 Subject: [PATCH 6/8] Use latest makexpi --- makexpi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/makexpi b/makexpi index 4c4c7fa4..b77413dd 160000 --- a/makexpi +++ b/makexpi @@ -1 +1 @@ -Subproject commit 4c4c7fa463c939c7027935347e117bb066f0fef2 +Subproject commit b77413ddf78ef19aab1c29a0e7bc96c164d0f300 From 355c073099884d553c44d331246c4d8fa9347cfe Mon Sep 17 00:00:00 2001 From: YUKI Hiroshi Date: Wed, 15 Jun 2016 14:26:14 +0900 Subject: [PATCH 7/8] Bump maxVersion to 50.0a1 --- install.rdf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/install.rdf b/install.rdf index 7609c439..8db32f88 100644 --- a/install.rdf +++ b/install.rdf @@ -262,7 +262,7 @@ + em:maxVersion="50.0a1" /> From cdc3a181ac657bb8d3592de35eb6f3943ae526a6 Mon Sep 17 00:00:00 2001 From: YUKI Hiroshi Date: Wed, 15 Jun 2016 14:27:05 +0900 Subject: [PATCH 8/8] Bump version to 0.17.2016061501 --- history.en.md | 1 + history.ja.md | 1 + install.rdf | 2 +- 3 files changed, 3 insertions(+), 1 deletion(-) diff --git a/history.en.md b/history.en.md index a7db90bb..147dd8bf 100644 --- a/history.en.md +++ b/history.en.md @@ -1,6 +1,7 @@ # History - master/HEAD + - 0.17.2016061501 * Scrollbar in the tab bar couldn't operated by mouse if you show the menu bar, at Firefox 47 on Windows. * The tab bar was wrongly fixed to "overflowed" state after you shrink the tab bar too narrow. * Better compatibility with the "Dark" theme of Firefox Developer Edition. diff --git a/history.ja.md b/history.ja.md index 6c365fe7..8671b84f 100644 --- a/history.ja.md +++ b/history.ja.md @@ -1,6 +1,7 @@ # 更新履歴 - master/HEAD + - 0.17.2016061501 * Firefox 47で、Windowsにおいてメニューバーを表示するとタブバー内のスクロールバーをマウスで操作できなくなる問題を修正 * タブバーの幅を極端に縮めた後、タブバーがoverflowの状態のままになることがあったのを修正 * Firefox Developer EditionのDarkテーマとの互換性を向上 diff --git a/install.rdf b/install.rdf index 8db32f88..541aacf6 100644 --- a/install.rdf +++ b/install.rdf @@ -5,7 +5,7 @@