stonewareslord/treestyletab
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Reduce use of eval()

Browse Source
This commit is contained in:
YUKI Hiroshi 2016-09-05 16:16:36 +09:00
parent 2ff3399300
commit 750ada61d8
1 changed files with 14 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
content/treestyletab/windowHelperHacks.js
View File

@ -432,33 +432,21 @@ TreeStyleTabWindowHelper.overrideExtensionsAfterBrowserInit = function TSTWH_ove
if ('mouselessbrowsing' in window && if ('mouselessbrowsing' in window &&
'EventHandler' in mouselessbrowsing && 'EventHandler' in mouselessbrowsing &&
TreeStyleTabUtils.getTreePref('compatibility.MouselessBrowsing')) { TreeStyleTabUtils.getTreePref('compatibility.MouselessBrowsing')) {
if ('execute' in mouselessbrowsing.EventHandler) { if ('execute' in mouselessbrowsing.EventHandler &&
eval('mouselessbrowsing.EventHandler.execute = '+ !mouselessbrowsing.EventHandler.__treestyletab__execute) {
mouselessbrowsing.EventHandler.execute.toSource().replace( mouselessbrowsing.EventHandler.__treestyletab__execute = mouselessbrowsing.EventHandler.execute;
'{', mouselessbrowsing.EventHandler.execute = function(...aArgs) {
'{ var Prefs = mlb_common.Prefs;'+ TreeStyleTabService.readyToOpenChildTabNow();
' var Utils = mlb_common.Utils;'+ return this.__treestyletab__execute(...aArgs);
' var MlbUtils = mouselessbrowsing.MlbUtils;' };
).replace(
/((?:var [^=]+ = )?Utils.openUrlInNewTab\()/g,
'TreeStyleTabService.readyToOpenChildTab(); $1'
)
);
} }
if ('openLinkInOtherLocationViaPostfixKey' in mouselessbrowsing.EventHandler) { if ('openLinkInOtherLocationViaPostfixKey' in mouselessbrowsing.EventHandler &&
eval('mouselessbrowsing.EventHandler.openLinkInOtherLocationViaPostfixKey = '+ !mouselessbrowsing.EventHandler.__treestyletab__openLinkInOtherLocationViaPostfixKey) {
mouselessbrowsing.EventHandler.openLinkInOtherLocationViaPostfixKey.toSource().replace( mouselessbrowsing.EventHandler.__treestyletab__openLinkInOtherLocationViaPostfixKey = mouselessbrowsing.EventHandler.openLinkInOtherLocationViaPostfixKey;
'{', mouselessbrowsing.EventHandler.openLinkInOtherLocationViaPostfixKey = function(...aArgs) {
'{ var Prefs = mlb_common.Prefs;'+ TreeStyleTabService.readyToOpenChildTabNow();
' var Utils = mlb_common.Utils;'+ return this.__treestyletab__openLinkInOtherLocationViaPostfixKey(...aArgs);
' var MlbUtils = mouselessbrowsing.MlbUtils;'+ };
' var MlbCommon = mouselessbrowsing.MlbCommon;'+
' var ShortcutManager = mlb_common.ShortcutManager;'
).replace(
'Utils.openUrlInNewTab(',
'TreeStyleTabService.readyToOpenChildTab(); $&'
)
);
} }
} }