From 3b692b4de47526a27771a638cd32b17c98a57826 Mon Sep 17 00:00:00 2001
From: Piro / YUKI Hiroshi <piro.outsider.reflex@gmail.com>
Date: Sun, 23 Sep 2012 16:11:03 +0900
Subject: [PATCH] Reduce usecases of evaluateXPath()

---
 content/treestyletab/treestyletab.xul | 16 ++----
 modules/browser.js                    | 77 ++++++++-------------------
 2 files changed, 26 insertions(+), 67 deletions(-)

diff --git a/content/treestyletab/treestyletab.xul b/content/treestyletab/treestyletab.xul
index 83a9b7dc..8d936727 100644
--- a/content/treestyletab/treestyletab.xul
+++ b/content/treestyletab/treestyletab.xul
@@ -65,9 +65,7 @@
 				event.stopPropagation();
 				this.parentNode.hidePopup();
 			}"
-			multipletab-insertafter="TreeStyleTabService.evaluateXPath(
-				&quot;descendant::*[starts-with(@id, 'context_reloadTab')][1]&quot;
-			, tabContextMenu, XPathResult.FIRST_ORDERED_NODE_TYPE).singleNodeValue"/>
+			multipletab-insertafter="tabContextMenu.querySelector(&quot;*[id^='context_reloadTab']&quot)"/>
 		<menuitem id="context-item-reloadDescendantTabs"
 			label="&context.reloadDescendantTabs.label;"
 			accesskey="&context.reloadDescendantTabs.accesskey;"
@@ -77,9 +75,7 @@
 				event.stopPropagation();
 				this.parentNode.hidePopup();
 			}"
-			multipletab-insertafter="TreeStyleTabService.evaluateXPath(
-				&quot;descendant::*[starts-with(@id, 'context-item-reloadTabSubtree')][1]&quot;
-			, tabContextMenu, XPathResult.FIRST_ORDERED_NODE_TYPE).singleNodeValue"/>
+			multipletab-insertafter="tabContextMenu.querySelector(&quot;*[id^='context-item-reloadTabSubtree']&quot)"/>
 
 		<menuitem id="context-item-removeTabSubtree"
 			label="&context.removeTabSubtree.label;"
@@ -102,16 +98,12 @@
 				event.stopPropagation();
 				this.parentNode.hidePopup();
 			}"
-			multipletab-insertafter="TreeStyleTabService.evaluateXPath(
-				&quot;descendant::*[starts-with(@id, 'context-item-removeTabSubtree')][1]&quot;
-			, tabContextMenu, XPathResult.FIRST_ORDERED_NODE_TYPE).singleNodeValue"/>
+			multipletab-insertafter="tabContextMenu.querySelector(&quot;*[id^='context-item-removeTabSubtree']&quot)"/>
 		<menuitem id="context-item-removeAllTabsButThisTree"
 			label="&context.removeAllTabsBut.label;"
 			accesskey="&context.removeAllTabsBut.accesskey;"
 			oncommand="TreeStyleTabService.removeAllTabsBut(TreeStyleTabService.getTabBrowserFromChild(this).mContextTab);"
-			multipletab-insertafter="TreeStyleTabService.evaluateXPath(
-				&quot;descendant::*[starts-with(@id, 'context_closeOtherTabs')][1]&quot;
-			, tabContextMenu, XPathResult.FIRST_ORDERED_NODE_TYPE).singleNodeValue"/>
+			multipletab-insertafter="tabContextMenu.querySelector(&quot;*[id^='context_closeOtherTabs']&quot)"/>
 
 		<menuitem id="context-item-bookmarkTabSubtree"
 			label="&context.bookmarkTabSubtree.label;"
diff --git a/modules/browser.js b/modules/browser.js
index 95a2aa55..325f19ad 100644
--- a/modules/browser.js
+++ b/modules/browser.js
@@ -4280,13 +4280,8 @@ TreeStyleTabBrowser.prototype = {
 
 		var nextTab = (aDir < 0) ? this.getPreviousVisibleTab(tab) : this.getNextVisibleTab(tab) ;
 		if (!nextTab && aWrap) {
-			nextTab = this.evaluateXPath(
-					'child::xul:tab[not(@'+this.kCOLLAPSED+'="true")]['+
-					(aDir < 0 ? 'last()' : '1' )+
-					']',
-					tabbar,
-					Ci.nsIDOMXPathResult.FIRST_ORDERED_NODE_TYPE
-				).singleNodeValue;
+			let tabs = tabbar.querySelectorAll('tab:not(['+this.kCOLLAPSED+'="true"])');
+			nextTab = tabs[aDir < 0 ? tabs.length-1 : 0 ];
 		}
 		if (nextTab && nextTab != tab)
 			tabbar._selectNewTab(nextTab, aDir, aWrap);
@@ -4473,11 +4468,7 @@ TreeStyleTabBrowser.prototype = {
 		for (let i = 0, maxi = ids.length; i < maxi; i++)
 		{
 			let id = ids[i];
-			let item = this.evaluateXPath(
-				'descendant::xul:*[starts-with(@id, "'+id+'")]',
-				aEvent.currentTarget,
-				Ci.nsIDOMXPathResult.FIRST_ORDERED_NODE_TYPE
-			).singleNodeValue;
+			let item = aEvent.currentTarget.querySelector('*[id^="'+id+'"]');
 			if (!item) continue;
 			items[id] = item;
 			if (this.getTreePref('show.'+id))
@@ -4502,33 +4493,20 @@ TreeStyleTabBrowser.prototype = {
 		}
 
 		// collapse/expand all
-		sep = this.evaluateXPath(
-			'descendant::xul:menuseparator[starts-with(@id, "'+this.kMENUITEM_COLLAPSEEXPAND_SEPARATOR+'")]',
-			aEvent.currentTarget,
-			Ci.nsIDOMXPathResult.FIRST_ORDERED_NODE_TYPE
-		).singleNodeValue;
+		sep = aEvent.currentTarget.querySelector('menuseparator[id^="'+this.kMENUITEM_COLLAPSEEXPAND_SEPARATOR+'"]');
 		let collapseItem = items[this.kMENUITEM_COLLAPSE];
 		let expandItem = items[this.kMENUITEM_EXPAND];
 		if (this.canCollapseSubtree(b) &&
-			this.evaluateXPath(
-				'child::xul:tab[@'+this.kCHILDREN+']',
-				b.mTabContainer
-			).snapshotLength) {
+			b.mTabContainer.querySelector('tab['+this.kCHILDREN+']')) {
 			if (collapseItem) {
-				if (this.evaluateXPath(
-						'child::xul:tab[@'+this.kCHILDREN+' and not(@'+this.kSUBTREE_COLLAPSED+'="true")]',
-						b.mTabContainer
-					).snapshotLength)
+				if (b.mTabContainer.querySelector('tab['+this.kCHILDREN+']:not(['+this.kSUBTREE_COLLAPSED+'="true"])'))
 					collapseItem.removeAttribute('disabled');
 				else
 					collapseItem.setAttribute('disabled', true);
 			}
 
 			if (expandItem) {
-				if (this.evaluateXPath(
-						'child::xul:tab[@'+this.kCHILDREN+' and @'+this.kSUBTREE_COLLAPSED+'="true"]',
-						b.mTabContainer
-					).snapshotLength)
+				if (b.mTabContainer.querySelector('tab['+this.kCHILDREN+']['+this.kSUBTREE_COLLAPSED+'="true"]'))
 					expandItem.removeAttribute('disabled');
 				else
 					expandItem.setAttribute('disabled', true);
@@ -4585,11 +4563,7 @@ TreeStyleTabBrowser.prototype = {
 				fixed.removeAttribute('checked');
 		}
 
-		sep = this.evaluateXPath(
-			'descendant::xul:menuseparator[starts-with(@id, "'+this.kMENUITEM_AUTOHIDE_SEPARATOR+'")]',
-			aEvent.currentTarget,
-			Ci.nsIDOMXPathResult.FIRST_ORDERED_NODE_TYPE
-		).singleNodeValue;
+		sep = aEvent.currentTarget.querySelector('menuseparator[id^="'+this.kMENUITEM_AUTOHIDE_SEPARATOR+'"]');
 		if (sep) {
 			if (
 				(autohide && autohide.getAttribute('hidden') != 'true') ||
@@ -5289,13 +5263,12 @@ TreeStyleTabBrowser.prototype = {
 		}
 
 		var b    = this.mTabBrowser;
-		var tabs = this.getArrayFromXPathResult(this.evaluateXPath(
-				'child::xul:tab['+
-					'@'+this.kNEST+' and not(@'+this.kNEST+'="0" or @'+this.kNEST+'="") and '+
-					'not(@'+this.kCOLLAPSED+'="true") and '+
-					'not(@hidden="true") and '+
-					'not(@collapsed="true")]',
-				b.mTabContainer
+		var tabs = Array.slice(b.mTabContainer.querySelectorAll(
+				'tab['+this.kNEST+']:not(['+this.kNEST+'="0"]):not(['+this.kNEST+'=""])'+
+					':not(['+this.kCOLLAPSED+'="true"])'+
+					':not([hidden="true"])'+
+					':not([collapsed="true"])',
+				
 			));
 		if (!tabs.length) return;
 
@@ -5968,19 +5941,17 @@ TreeStyleTabBrowser.prototype = {
  
 	collapseExpandAllSubtree : function TSTBrowser_collapseExpandAllSubtree(aCollapse, aJustNow) 
 	{
-		var xpathResult = this.evaluateXPath(
-				'child::xul:tab[@'+this.kID+' and @'+this.kCHILDREN+
+		var tabs = this.mTabBrowser.mTabContainer.querySelectorAll(
+				'tab['+this.kID+']['+this.kCHILDREN+']'+
 				(
 					aCollapse ?
-						' and not(@'+this.kSUBTREE_COLLAPSED+'="true")' :
-						' and @'+this.kSUBTREE_COLLAPSED+'="true"'
-				)+
-				']',
-				this.mTabBrowser.mTabContainer
+						':not(['+this.kSUBTREE_COLLAPSED+'="true"])' :
+						'['+this.kSUBTREE_COLLAPSED+'="true"]'
+				),
 			);
-		for (var i = 0, maxi = xpathResult.snapshotLength; i < maxi; i++)
+		for (var i = 0, maxi = tabs.length; i < maxi; i++)
 		{
-			this.collapseExpandSubtree(xpathResult.snapshotItem(i), aCollapse, aJustNow);
+			this.collapseExpandSubtree(tabs[i], aCollapse, aJustNow);
 		}
 	},
   
@@ -6049,11 +6020,7 @@ TreeStyleTabBrowser.prototype = {
 							oldSize[0] < newSize[0] || oldSize[1] < newSize[1] ||
 							// there are still animating tabs
 							self.getXOffsetOfTab(lastTab) || self.getYOffsetOfTab(lastTab) ||
-							self.evaluateXPath(
-								'child::xul:tab[@'+self.kCOLLAPSING_PHASE+'="'+self.kCOLLAPSING_PHASE_TO_BE_EXPANDED+'"]',
-								self.mTabBrowser.mTabContainer,
-								Ci.nsIDOMXPathResult.BOOLEAN_TYPE
-							).booleanValue
+							self.mTabBrowser.mTabContainer.querySelector('tab['+self.kCOLLAPSING_PHASE+'="'+self.kCOLLAPSING_PHASE_TO_BE_EXPANDED+'"]')
 							)
 							self.smoothScrollTo(aEndX, aEndY, parseInt(aDuration * 0.5));
 						self = null;