diff --git a/src/set.rs b/src/set.rs index adf0ad3..36b1ec7 100644 --- a/src/set.rs +++ b/src/set.rs @@ -168,7 +168,8 @@ fn reduce_selections( options.ignore_case, ); - if key_set_operation_result.contains(&key) { + // TODO: Do not allocate + if key_set_operation_result.contains(&key.into_owned()) { Some(swd.desc) } else { None @@ -268,6 +269,7 @@ fn to_ordered_counts(options: &Options, sels: Vec) -> LinkedHashMap) -> LinkedHashMap( + selection: &'sel str, + preserve_whitespace: bool, regex: Option<&Regex>, ignore_case: bool, -) -> String { +) -> Cow<'sel, str> { // Strip whitespace if requested - let mut key = if skip_whitespace { - selection.as_str() + let mut key = if preserve_whitespace { + // TODO: Does this need to be swapped? + selection } else { selection.trim() }; // If they requested a regex match, set the key to the string slice of that match if let Some(regex_match) = (|| { - let captures = regex.as_ref()?.captures(key)?; + // let captures = regex.as_ref()?.captures(&key)?; + let captures = regex.as_ref()?.captures(key.borrow())?; captures .get(1) .or_else(|| captures.get(0)) .map(|m| m.as_str()) })() { key = regex_match; + // Cow::Borrowed(regex_match) } // Ignore case if requested - // Lowercase at the end to not mangle regex if ignore_case { - key.to_lowercase() + // Lowercase at the end to not mangle regex + // TODO: Do not allocate if it is already lowercased + // Need to_lowercase(&self) -> Cow + if !key.as_bytes().iter().any(u8::is_ascii_uppercase) { + Cow::Borrowed(key) + } else { + Cow::Owned(key.to_ascii_lowercase()) + } } else { - // TODO: Do not perform an allocation here - key.to_string() + Cow::Borrowed(key) } } /// Get a key out of a selection based on options pub fn get_hash( // TODO: Accept any Into> - selection: &Selection, - skip_whitespace: bool, + selection: &str, + preserve_whitespace: bool, regex: Option<&Regex>, ignore_case: bool, ) -> u64 { let mut hasher = DefaultHasher::new(); - get_key(selection, skip_whitespace, regex, ignore_case).hash(&mut hasher); + get_key(&selection, preserve_whitespace, regex, ignore_case).hash(&mut hasher); hasher.finish() } diff --git a/src/xlookup.rs b/src/xlookup.rs index 41475ec..a1c579f 100644 --- a/src/xlookup.rs +++ b/src/xlookup.rs @@ -22,7 +22,7 @@ pub fn xlookup(options: &Options) -> Result { set_selections(selections.iter().map(|key| { lookup_table - .get(&get_hash(key, false, None, false)) + .get(&get_hash(&key, false, None, false)) .map_or_else( || { eprintln!("Key '{key}' not found",); @@ -48,7 +48,7 @@ pub fn xlookup(options: &Options) -> Result { fn build_lookuptable(mut selections: Vec) -> Result, KakError> { let mut iter = selections.array_chunks_mut(); let ret = iter.try_fold(BTreeMap::new(), |mut acc, [key, value]| { - match acc.entry(get_hash(key, false, None, false)) { + match acc.entry(get_hash(&key, false, None, false)) { Occupied(_) => Err(KakError::Custom(format!("Duplicate key '{key}'"))), Vacant(v) => { v.insert(value.clone()); @@ -76,7 +76,7 @@ mod tests { } macro_rules! hsh { ($expr:expr) => { - get_hash(&$expr.to_string(), false, None, false) + get_hash($expr, false, None, false) }; } #[test]