From 4ef32454138a40c8b3cc5334c8980e71bd431825 Mon Sep 17 00:00:00 2001 From: Peter Smit Date: Thu, 22 Jan 2015 15:01:45 +0200 Subject: [PATCH] Migration code: errors are not to be forgotten --- models/migrations/migrations.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/models/migrations/migrations.go b/models/migrations/migrations.go index e51bc3c8..3586e5d0 100644 --- a/models/migrations/migrations.go +++ b/models/migrations/migrations.go @@ -20,7 +20,9 @@ var migrations = []migration{} // Migrate database to current version func Migrate(x *xorm.Engine) error { - x.Sync(new(Version)) + if err := x.Sync(new(Version)); err != nil { + return err + } currentVersion := &Version{Id: 1} has, err := x.Get(currentVersion) @@ -39,7 +41,9 @@ func Migrate(x *xorm.Engine) error { return err } currentVersion.Version = v + int64(i) + 1 - x.Id(1).Update(currentVersion) + if _, err = x.Id(1).Update(currentVersion); err != nil { + return err + } } return nil }