328035fb7e
We already claim _NET_WM_DESKTOP support in _NET_SUPPORTED since around 2009, but haven't actually done anything with it. However, especially pagers like gnome-panel rely on this property to be updated and many tools, like GTK, want to use the corresponding client messages to make a window sticky, move it around etc. This patch implements full support according to the EWMH spec. This means: * We set the property on all windows when managing it. * We keep the property updated on all windows at all times. * We read and respect the property upon managing a window if it was set before mapping the window. * We react to client messages for it. * We remove the property on withdrawn windows. Note that the special value 0xFFFFFFFF, according to the spec, means that the window shall be shown on all workspaces. We do this by making it sticky and float it. This shows it on all workspaces at least on the output it is on. Furthermore, the spec gives us the freedom to ignore _NET_WM_DESKTOP when managing a window if we have good reason to. In our case, we give window swallowing a higher priority since the user would likely expect that and we want to keep placeholder windows only around for as long as we have to. However, we do prioritize this property over, for example, startup notifications. fixes #2153 fixes #1507 fixes #938
70 lines
2.0 KiB
Perl
70 lines
2.0 KiB
Perl
#!perl
|
|
# vim:ts=4:sw=4:expandtab
|
|
#
|
|
# Please read the following documents before working on tests:
|
|
# • http://build.i3wm.org/docs/testsuite.html
|
|
# (or docs/testsuite)
|
|
#
|
|
# • http://build.i3wm.org/docs/lib-i3test.html
|
|
# (alternatively: perldoc ./testcases/lib/i3test.pm)
|
|
#
|
|
# • http://build.i3wm.org/docs/ipc.html
|
|
# (or docs/ipc)
|
|
#
|
|
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
|
|
# (unless you are already familiar with Perl)
|
|
#
|
|
# Ticket: #1873
|
|
use i3test;
|
|
use X11::XCB qw(:all);
|
|
|
|
sub get_wm_state {
|
|
sync_with_i3;
|
|
|
|
my ($con) = @_;
|
|
my $cookie = $x->get_property(
|
|
0,
|
|
$con->{id},
|
|
$x->atom(name => '_NET_WM_STATE')->id,
|
|
GET_PROPERTY_TYPE_ANY,
|
|
0,
|
|
4096
|
|
);
|
|
|
|
my $reply = $x->get_property_reply($cookie->{sequence});
|
|
my $len = $reply->{length};
|
|
return 0 if $len == 0;
|
|
|
|
my @atoms = unpack("L$len", $reply->{value});
|
|
return \@atoms;
|
|
}
|
|
|
|
my $wm_state_sticky = $x->atom(name => '_NET_WM_STATE_STICKY')->id;
|
|
my $wm_state_fullscreen = $x->atom(name => '_NET_WM_STATE_FULLSCREEN')->id;
|
|
|
|
##########################################################################
|
|
# Given a sticky container, when it is fullscreened, then both wm state
|
|
# atoms are set. When the container is unfullscreened, then only the
|
|
# sticky atom is still set.
|
|
##########################################################################
|
|
|
|
fresh_workspace;
|
|
my $window = open_window;
|
|
cmd 'sticky enable';
|
|
is_deeply(get_wm_state($window), [ $wm_state_sticky ], 'sanity check: _NET_WM_STATE_STICKY is set');
|
|
|
|
cmd 'fullscreen enable';
|
|
is_deeply(get_wm_state($window), [ $wm_state_sticky, $wm_state_fullscreen ],
|
|
'both _NET_WM_STATE_FULLSCREEN and _NET_WM_STATE_STICKY are set');
|
|
|
|
cmd 'sticky disable';
|
|
is_deeply(get_wm_state($window), [ $wm_state_fullscreen ], 'only _NET_WM_STATE_FULLSCREEN is set');
|
|
|
|
cmd 'sticky enable';
|
|
cmd 'fullscreen disable';
|
|
is_deeply(get_wm_state($window), [ $wm_state_sticky ], 'only _NET_WM_STATE_STICKY is set');
|
|
|
|
##########################################################################
|
|
|
|
done_testing;
|