328035fb7e
We already claim _NET_WM_DESKTOP support in _NET_SUPPORTED since around 2009, but haven't actually done anything with it. However, especially pagers like gnome-panel rely on this property to be updated and many tools, like GTK, want to use the corresponding client messages to make a window sticky, move it around etc. This patch implements full support according to the EWMH spec. This means: * We set the property on all windows when managing it. * We keep the property updated on all windows at all times. * We read and respect the property upon managing a window if it was set before mapping the window. * We react to client messages for it. * We remove the property on withdrawn windows. Note that the special value 0xFFFFFFFF, according to the spec, means that the window shall be shown on all workspaces. We do this by making it sticky and float it. This shows it on all workspaces at least on the output it is on. Furthermore, the spec gives us the freedom to ignore _NET_WM_DESKTOP when managing a window if we have good reason to. In our case, we give window swallowing a higher priority since the user would likely expect that and we want to keep placeholder windows only around for as long as we have to. However, we do prioritize this property over, for example, startup notifications. fixes #2153 fixes #1507 fixes #938
351 lines
9.7 KiB
Perl
351 lines
9.7 KiB
Perl
#!perl
|
|
# vim:ts=4:sw=4:expandtab
|
|
#
|
|
# Please read the following documents before working on tests:
|
|
# • http://build.i3wm.org/docs/testsuite.html
|
|
# (or docs/testsuite)
|
|
#
|
|
# • http://build.i3wm.org/docs/lib-i3test.html
|
|
# (alternatively: perldoc ./testcases/lib/i3test.pm)
|
|
#
|
|
# • http://build.i3wm.org/docs/ipc.html
|
|
# (or docs/ipc)
|
|
#
|
|
# • http://onyxneon.com/books/modern_perl/modern_perl_a4.pdf
|
|
# (unless you are already familiar with Perl)
|
|
#
|
|
# Tests for _NET_WM_DESKTOP.
|
|
# Ticket: #2153
|
|
use i3test i3_autostart => 0;
|
|
use X11::XCB qw(:all);
|
|
|
|
###############################################################################
|
|
|
|
sub get_net_wm_desktop {
|
|
sync_with_i3;
|
|
|
|
my ($con) = @_;
|
|
my $cookie = $x->get_property(
|
|
0,
|
|
$con->{id},
|
|
$x->atom(name => '_NET_WM_DESKTOP')->id,
|
|
$x->atom(name => 'CARDINAL')->id,
|
|
0,
|
|
1
|
|
);
|
|
|
|
my $reply = $x->get_property_reply($cookie->{sequence});
|
|
return undef if $reply->{length} != 1;
|
|
|
|
return unpack("L", $reply->{value});
|
|
}
|
|
|
|
sub send_net_wm_desktop {
|
|
my ($con, $idx) = @_;
|
|
my $msg = pack "CCSLLLLLL",
|
|
X11::XCB::CLIENT_MESSAGE, 32, 0,
|
|
$con->{id},
|
|
$x->atom(name => '_NET_WM_DESKTOP')->id,
|
|
$idx, 0, 0, 0, 0;
|
|
|
|
$x->send_event(0, $x->get_root_window(), X11::XCB::EVENT_MASK_SUBSTRUCTURE_REDIRECT, $msg);
|
|
sync_with_i3;
|
|
}
|
|
|
|
sub open_window_with_net_wm_desktop {
|
|
my $idx = shift;
|
|
my $window = open_window(
|
|
before_map => sub {
|
|
my ($window) = @_;
|
|
$x->change_property(
|
|
PROP_MODE_REPLACE,
|
|
$window->id,
|
|
$x->atom(name => '_NET_WM_DESKTOP')->id,
|
|
$x->atom(name => 'CARDINAL')->id,
|
|
32, 1,
|
|
pack('L', $idx),
|
|
);
|
|
},
|
|
);
|
|
|
|
return $window;
|
|
}
|
|
|
|
# We need to kill all windows in between tests since they survive the i3 restart
|
|
# and will interfere with the following tests.
|
|
sub kill_windows {
|
|
sync_with_i3;
|
|
cmd '[title="Window.*"] kill';
|
|
}
|
|
|
|
###############################################################################
|
|
|
|
my ($config, $config_mm, $pid, $con);
|
|
|
|
$config = <<EOT;
|
|
# i3 config file (v4)
|
|
font -misc-fixed-medium-r-normal--13-120-75-75-C-70-iso10646-1
|
|
|
|
bar {
|
|
status_command i3status
|
|
}
|
|
EOT
|
|
|
|
$config_mm = <<EOT;
|
|
# i3 config file (v4)
|
|
font -misc-fixed-medium-r-normal--13-120-75-75-C-70-iso10646-1
|
|
|
|
workspace "0" output "fake-0"
|
|
workspace "1" output "fake-0"
|
|
workspace "2" output "fake-0"
|
|
workspace "10" output "fake-1"
|
|
workspace "11" output "fake-1"
|
|
workspace "12" output "fake-1"
|
|
|
|
fake-outputs 1024x768+0+0,1024x768+1024+0
|
|
EOT
|
|
|
|
###############################################################################
|
|
# Upon managing a window which does not set _NET_WM_DESKTOP, the property is
|
|
# set on the window.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 1';
|
|
$con = open_window;
|
|
|
|
is(get_net_wm_desktop($con), 0, '_NET_WM_DESKTOP is set upon managing a window');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# Upon managing a window which sets _NET_WM_DESKTOP, the window is moved to
|
|
# the specified desktop.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
open_window;
|
|
cmd 'workspace 1';
|
|
open_window;
|
|
cmd 'workspace 2';
|
|
open_window;
|
|
|
|
$con = open_window_with_net_wm_desktop(1);
|
|
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP still has the correct value');
|
|
is_num_children('1', 2, 'The window was moved to workspace 1');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# Upon managing a window which sets _NET_WM_DESKTOP to the appropriate value,
|
|
# the window is made sticky and floating.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
$con = open_window_with_net_wm_desktop(0xFFFFFFFF);
|
|
|
|
is(get_net_wm_desktop($con), 0xFFFFFFFF, '_NET_WM_DESKTOP still has the correct value');
|
|
is(@{get_ws('0')->{floating_nodes}}, 1, 'The window is floating');
|
|
ok(get_ws('0')->{floating_nodes}->[0]->{nodes}->[0]->{sticky}, 'The window is sticky');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when the window is moved to another workspace
|
|
# on the same output.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
open_window;
|
|
cmd 'workspace 1';
|
|
open_window;
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
|
|
cmd 'move window to workspace 1';
|
|
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP is updated when moving the window');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when the floating window is moved to another
|
|
# workspace on the same output.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
open_window;
|
|
cmd 'workspace 1';
|
|
open_window;
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
cmd 'floating enable';
|
|
|
|
cmd 'move window to workspace 1';
|
|
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP is updated when moving the window');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when the window is moved to another workspace
|
|
# on another output.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config_mm);
|
|
|
|
cmd 'workspace 0';
|
|
open_window;
|
|
cmd 'workspace 10';
|
|
open_window;
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
|
|
cmd 'move window to workspace 10';
|
|
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP is updated when moving the window');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is removed when the window is withdrawn.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
$con = open_window;
|
|
is(get_net_wm_desktop($con), 0, '_NET_WM_DESKTOP is set (sanity check)');
|
|
|
|
$con->unmap;
|
|
wait_for_unmap($con);
|
|
|
|
is(get_net_wm_desktop($con), undef, '_NET_WM_DESKTOP is removed');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# A _NET_WM_DESKTOP client message sent to the root window moves a window
|
|
# to the correct workspace.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
open_window;
|
|
cmd 'workspace 1';
|
|
open_window;
|
|
cmd 'workspace 0';
|
|
|
|
$con = open_window;
|
|
is_num_children('0', 2, 'The window is on workspace 0');
|
|
|
|
send_net_wm_desktop($con, 1);
|
|
|
|
is_num_children('0', 1, 'The window is no longer on workspace 0');
|
|
is_num_children('1', 2, 'The window is now on workspace 1');
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP is updated');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# A _NET_WM_DESKTOP client message sent to the root window can make a window
|
|
# sticky.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
|
|
send_net_wm_desktop($con, 0xFFFFFFFF);
|
|
|
|
is(get_net_wm_desktop($con), 0xFFFFFFFF, '_NET_WM_DESKTOP is updated');
|
|
is(@{get_ws('0')->{floating_nodes}}, 1, 'The window is floating');
|
|
ok(get_ws('0')->{floating_nodes}->[0]->{nodes}->[0]->{sticky}, 'The window is sticky');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when a new workspace with a lower number is
|
|
# opened and closed.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 1';
|
|
$con = open_window;
|
|
is(get_net_wm_desktop($con), 0, '_NET_WM_DESKTOP is set sanity check)');
|
|
|
|
cmd 'workspace 0';
|
|
is(get_net_wm_desktop($con), 1, '_NET_WM_DESKTOP is updated');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when a window is made sticky by command.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
cmd 'floating enable';
|
|
is(get_net_wm_desktop($con), 0, '_NET_WM_DESKTOP is set sanity check)');
|
|
|
|
cmd 'sticky enable';
|
|
is(get_net_wm_desktop($con), 0xFFFFFFFF, '_NET_WM_DESKTOP is updated');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
# _NET_WM_DESKTOP is updated when a window is made sticky by client message.
|
|
###############################################################################
|
|
|
|
$pid = launch_with_config($config);
|
|
|
|
cmd 'workspace 0';
|
|
$con = open_window;
|
|
cmd 'floating enable';
|
|
is(get_net_wm_desktop($con), 0, '_NET_WM_DESKTOP is set sanity check)');
|
|
|
|
my $msg = pack "CCSLLLLLL",
|
|
X11::XCB::CLIENT_MESSAGE, 32, 0,
|
|
$con->{id},
|
|
$x->atom(name => '_NET_WM_STATE')->id,
|
|
1,
|
|
$x->atom(name => '_NET_WM_STATE_STICKY')->id,
|
|
0, 0, 0;
|
|
|
|
$x->send_event(0, $x->get_root_window(), X11::XCB::EVENT_MASK_SUBSTRUCTURE_REDIRECT, $msg);
|
|
sync_with_i3;
|
|
|
|
is(get_net_wm_desktop($con), 0xFFFFFFFF, '_NET_WM_DESKTOP is updated');
|
|
|
|
kill_windows;
|
|
exit_gracefully($pid);
|
|
|
|
###############################################################################
|
|
|
|
done_testing;
|