applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: insert id-based match at HEAD, not TAIL.

Browse Source 
Before this commit, placeholder windows had any matches that were
defined in the JSON file, _followed_ by an i3-internal match that
ensures the placeholder X11 window gets swallowed into the placeholder
i3 container.

The problem was that the first successful match was deleted, and if
users specified a criterion (title=IPython) that matched the placeholder
window itself (name=IPython), then that match is deleted and the
i3-internal match is kept. This results in the actual window the user
wants to match not being swallowed, and the placeholder window not
displaying any criteria.

fixes #1526
This commit is contained in:
Michael Stapelberg 2015-03-07 15:38:10 +01:00
parent fa3396b6ea
commit df1fcdafe8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/restore_layout.c
View File

@ -219,7 +219,7 @@ static void open_placeholder_window(Con *con) {
Match *temp_id = smalloc(sizeof(Match));
match_init(temp_id);
temp_id->id = placeholder;
TAILQ_INSERT_TAIL(&(con->swallow_head), temp_id, matches);
TAILQ_INSERT_HEAD(&(con->swallow_head), temp_id, matches);
}
Con *child;