applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Document tray initialization better.

Browse Source 
This commit removes an unnecessary fallback to the first output's name as
this name ("first") will only be used to see whether "tray_output none"
has been specified, anyway.

We also add documentation that clearly states when we want to initialize
the tray and when we don't want to do the same.

relates to #2220
This commit is contained in:
Ingo Bürk 2016-02-21 14:26:13 +01:00
parent 320591ac19
commit b8109c3a59
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
i3bar/src/xcb.c
View File

@ -1761,16 +1761,35 @@ void reconfig_windows(bool redraw_bars) {
} }
/* Unless "tray_output none" was specified, we need to initialize the tray. */ /* Unless "tray_output none" was specified, we need to initialize the tray. */
const char *first = (TAILQ_EMPTY(&(config.tray_outputs))) ? SLIST_FIRST(outputs)->name : TAILQ_FIRST(&(config.tray_outputs))->output; bool no_tray = false;
if (!tray_configured && strcasecmp(first, "none") != 0) { if (!(TAILQ_EMPTY(&(config.tray_outputs)))) {
/* We do a sanity check here to ensure that this i3bar instance actually handles no_tray = strcasecmp(TAILQ_FIRST(&(config.tray_outputs))->output, "none") == 0;
* the output on which the tray should appear. For example, }
* consider tray_output == [VGA-1], but output == [HDMI-1]. */
/*
* There are three scenarios in which we need to initialize the tray:
* 1. A specific output was listed in tray_outputs which is also
* in the list of outputs managed by this bar.
* 2. No tray_output directive was specified. In this case, we
* use the first available output.
* 3. 'tray_output primary' was specified. In this case we use the
* primary output.
*
* Three scenarios in which we specifically don't want to
* initialize the tray are:
* 1. 'tray_output none' was specified.
* 2. A specific output was listed as a tray_output, but is not
* one of the outputs managed by this bar. For example, consider
* tray_outputs == [VGA-1], but outputs == [HDMI-1].
* 3. 'tray_output primary' was specified and no output in the list
* is primary.
*/
if (!tray_configured && !no_tray) {
/* If no tray_output was specified, we go ahead and initialize the tray as /* If no tray_output was specified, we go ahead and initialize the tray as
* we will be using the first available output. */ * we will be using the first available output. */
if (TAILQ_EMPTY(&(config.tray_outputs))) if (TAILQ_EMPTY(&(config.tray_outputs))) {
init_tray(); init_tray();
}
/* If one or more tray_output assignments were specified, we ensure that at least one of /* If one or more tray_output assignments were specified, we ensure that at least one of
* them is actually an output managed by this instance. */ * them is actually an output managed by this instance. */