applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bugfix: always reset state->initial to false, not only for different stacking order

Browse Source 
As initial may be set to true again after initializing the window, we need to
ensure that it is properly cleared. Otherwise, this leads to ghost windows when
unmapping (such as the Xpdf about dialog) due to i3 issuing MapWindow after an
Unmap happened but before i3 actually received/handled the UnmapNotify.
This commit is contained in:
Michael Stapelberg 2010-11-26 20:15:08 +01:00
parent 97bc8f4b86
commit b2db9ac797
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/x.c
View File

@ -539,7 +539,6 @@ void x_push_changes(Con *con) {
if (prev != old_prev)
order_changed = true;
if ((state->initial || order_changed) && prev != CIRCLEQ_END(&state_head)) {
state->initial = false;
LOG("Stacking 0x%08x above 0x%08x\n", prev->id, state->id);
uint32_t mask = 0;
mask |= XCB_CONFIG_WINDOW_SIBLING;
@ -548,6 +547,7 @@ void x_push_changes(Con *con) {
xcb_configure_window(conn, prev->id, mask, values);
}
state->initial = false;
}
xcb_window_t to_focus = focused->frame;