applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix crash: urgent floating con on separate workspace (thanks Piotr)

Browse Source 
If there is a single floating con on a separate workspace that is not
focused, and this con becomes urgent, switching back to that workspace
may result in a crash of i3. This is because while setting the urgency
of parent containers, 'parent' may become NULL in case of floating
containers. This commit checks the validity of parent.

fixes #821
This commit is contained in:
Simon Elsbrock 2012-09-27 08:35:09 +02:00 committed by Michael Stapelberg
parent dcf95fd312
commit 87525ad2d6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/con.c
View File

@ -1424,7 +1424,7 @@ void con_update_parents_urgency(Con *con) {
Con *parent = con->parent; Con *parent = con->parent;
bool new_urgency_value = con->urgent; bool new_urgency_value = con->urgent;
while (parent->type != CT_WORKSPACE && parent->type != CT_DOCKAREA) { while (parent && parent->type != CT_WORKSPACE && parent->type != CT_DOCKAREA) {
if (new_urgency_value) { if (new_urgency_value) {
parent->urgent = true; parent->urgent = true;
} else { } else {