applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix scrolling in window decoration with hidden cursor.

Browse Source 
If the mouse cursor is hidden (by unclutter, for example), then scrolling
in the window decoration creates an event with a child
(i.e. event->child != XCB_NONE). This causes route_click() to be called
with dest=CLICK_INSIDE, which prevents scrolling through a stacked layout.

To fix this, check if a click is in the window decoration _before_
checking if the event has a child.
This commit is contained in:
Michael Tipton 2015-03-02 23:44:28 -08:00
parent 487ccb536a
commit 73ecc56bd7
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/click.c
View File

@ -380,11 +380,6 @@ int handle_button_press(xcb_button_press_event_t *event) {
return 0; return 0;
} }
if (event->child != XCB_NONE) {
DLOG("event->child not XCB_NONE, so this is an event which originated from a click into the application, but the application did not handle it.\n");
return route_click(con, event, mod_pressed, CLICK_INSIDE);
}
/* Check if the click was on the decoration of a child */ /* Check if the click was on the decoration of a child */
Con *child; Con *child;
TAILQ_FOREACH(child, &(con->nodes_head), nodes) { TAILQ_FOREACH(child, &(con->nodes_head), nodes) {
@ -394,5 +389,10 @@ int handle_button_press(xcb_button_press_event_t *event) {
return route_click(child, event, mod_pressed, CLICK_DECORATION); return route_click(child, event, mod_pressed, CLICK_DECORATION);
} }
if (event->child != XCB_NONE) {
DLOG("event->child not XCB_NONE, so this is an event which originated from a click into the application, but the application did not handle it.\n");
return route_click(con, event, mod_pressed, CLICK_INSIDE);
}
return route_click(con, event, mod_pressed, CLICK_BORDER); return route_click(con, event, mod_pressed, CLICK_BORDER);
} }