applications/i3
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

bugfix: correctly move cons out of floating cons when the workspace has no other tiling cons (Thanks mseed)

Browse Source
This commit is contained in:
Michael Stapelberg 2011-01-27 16:51:41 +01:00
parent 334e41daa4
commit 676afce540
1 changed files with 72 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
src/tree.c
View File

@ -384,7 +384,13 @@ void tree_move(char way, orientation_t orientation) {
* and the orientation still does not match. In this case, we split the * and the orientation still does not match. In this case, we split the
* workspace to have the same look & feel as in older i3 releases. */ * workspace to have the same look & feel as in older i3 releases. */
if (parent->type == CT_WORKSPACE) { if (parent->type == CT_WORKSPACE) {
DLOG("Arrived at workspace, splitting...\n"); DLOG("Arrived at workspace\n");
/* In case of moving a window out of a floating con, there might be
* not a single tiling container. Makes no sense to split then, so
* just use the workspace as target */
if (TAILQ_EMPTY(&(parent->nodes_head)))
break;
/* 1: create a new split container */ /* 1: create a new split container */
Con *new = con_new(NULL); Con *new = con_new(NULL);
new->parent = parent; new->parent = parent;
@ -430,6 +436,17 @@ void tree_move(char way, orientation_t orientation) {
Con *current = TAILQ_FIRST(&(parent->focus_head)); Con *current = TAILQ_FIRST(&(parent->focus_head));
assert(current != TAILQ_END(&(parent->focus_head))); assert(current != TAILQ_END(&(parent->focus_head)));
/* If we have no tiling cons (when moving a window out of a floating con to
* an otherwise empty workspace for example), we just attach the window to
* the workspace. */
if (TAILQ_EMPTY(&(parent->nodes_head))) {
con_detach(focused);
con_fix_percent(focused->parent);
focused->parent = parent;
TAILQ_INSERT_HEAD(&(parent->nodes_head), focused, nodes);
TAILQ_INSERT_HEAD(&(parent->focus_head), focused, focused);
} else {
/* 2: chose next (or previous) */ /* 2: chose next (or previous) */
Con *next = current; Con *next = current;
if (way == 'n') { if (way == 'n') {
@ -493,14 +510,15 @@ void tree_move(char way, orientation_t orientation) {
TAILQ_INSERT_HEAD(&(next->parent->focus_head), focused, focused); TAILQ_INSERT_HEAD(&(next->parent->focus_head), focused, focused);
/* TODO: don’t influence focus handling? */ /* TODO: don’t influence focus handling? */
} }
}
/* fix the percentages in the container we moved to */ /* fix the percentages in the container we moved to */
int children = con_num_children(next->parent); int children = con_num_children(focused->parent);
if (children == 1) if (children == 1)
focused->percent = 1.0; focused->percent = 1.0;
else else
focused->percent = 1.0 / (children - 1); focused->percent = 1.0 / (children - 1);
con_fix_percent(next->parent); con_fix_percent(focused->parent);
/* We need to call con_focus() to fix the focus stack "above" the container /* We need to call con_focus() to fix the focus stack "above" the container
* we just inserted the focused container into (otherwise, the parent * we just inserted the focused container into (otherwise, the parent