diff --git a/i3-input/main.c b/i3-input/main.c index f98afd3d..49db4df2 100644 --- a/i3-input/main.c +++ b/i3-input/main.c @@ -2,7 +2,7 @@ * vim:ts=4:sw=4:expandtab * * i3 - an improved dynamic tiling window manager - * © 2009-2011 Michael Stapelberg and contributors (see also: LICENSE) + * © 2009-2013 Michael Stapelberg and contributors (see also: LICENSE) * * i3-input/main.c: Utility which lets the user input commands and sends them * to i3. @@ -76,6 +76,24 @@ void errorlog(char *fmt, ...) { va_end(args); } +/* + * Restores the X11 input focus to whereever it was before. + * This is necessary because i3-input’s window has override_redirect=1 + * (→ unmanaged by the window manager) and thus i3-input changes focus itself. + * This function is called on exit(). + * + */ +static void restore_input_focus(void) { + xcb_generic_error_t *error; + xcb_get_input_focus_reply_t *reply = xcb_get_input_focus_reply(conn, focus_cookie, &error); + if (error != NULL) { + fprintf(stderr, "[i3-input] ERROR: Could not restore input focus (X error %d)\n", error->error_code); + return; + } + xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, reply->focus, XCB_CURRENT_TIME); + xcb_flush(conn); +} + /* * Concats the glyphs (either UCS-2 or UTF-8) to a single string, suitable for * rendering it (UCS-2) or sending it to i3 (UTF-8). @@ -187,6 +205,10 @@ static void finish_input() { /* prefix the command if a prefix was specified on commandline */ printf("command = %s\n", full); + restore_input_focus(); + + xcb_aux_sync(conn); + ipc_send_message(sockfd, strlen(full), 0, (uint8_t*)full); #if 0 @@ -239,6 +261,7 @@ static int handle_key_press(void *ignored, xcb_connection_t *conn, xcb_key_press return 1; } if (sym == XK_Escape) { + restore_input_focus(); exit(0); } @@ -283,24 +306,6 @@ static int handle_key_press(void *ignored, xcb_connection_t *conn, xcb_key_press return 1; } -/* - * Restores the X11 input focus to whereever it was before. - * This is necessary because i3-input’s window has override_redirect=1 - * (→ unmanaged by the window manager) and thus i3-input changes focus itself. - * This function is called on exit(). - * - */ -static void restore_input_focus(void) { - xcb_generic_error_t *error; - xcb_get_input_focus_reply_t *reply = xcb_get_input_focus_reply(conn, focus_cookie, &error); - if (error != NULL) { - fprintf(stderr, "[i3-input] ERROR: Could not restore input focus (X error %d)\n", error->error_code); - return; - } - xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, reply->focus, XCB_CURRENT_TIME); - xcb_flush(conn); -} - int main(int argc, char *argv[]) { format = strdup("%s"); socket_path = getenv("I3SOCK"); @@ -420,7 +425,6 @@ int main(int argc, char *argv[]) { /* Set input focus (we have override_redirect=1, so the wm will not do * this for us) */ xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, win, XCB_CURRENT_TIME); - atexit(restore_input_focus); /* Grab the keyboard to get all input */ xcb_flush(conn); @@ -440,6 +444,7 @@ int main(int argc, char *argv[]) { if (reply->status != XCB_GRAB_STATUS_SUCCESS) { fprintf(stderr, "Could not grab keyboard, status = %d\n", reply->status); + restore_input_focus(); exit(-1); }